components/components_tests.gyp - Issue 1932953002: [Offline pages] Empty RequestQueue and SavePageRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/components_tests.gyp

Issue 1932953002: [Offline pages] Empty RequestQueue and SavePageRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing nits from Pete Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/components_tests.gyp

diff --git a/components/components_tests.gyp b/components/components_tests.gyp

index ae48eb2061ea11f8c0303985db82e65a22d915b9..303d1d5405b5485fecfafc584a87eed153991c87 100644

--- a/components/components_tests.gyp

+++ b/components/components_tests.gyp

@@ -405,7 +405,10 @@

'ntp_snippets/inner_iterator_unittest.cc',

'ntp_snippets/ntp_snippets_service_unittest.cc',

- 'offline_page_unittest_sources': [

+ 'offline_pages_background_unittest_sources': [

+ 'offline_pages/background/save_page_request_unittest.cc',

+ ],

+ 'offline_pages_unittest_sources': [

'offline_pages/offline_page_metadata_store_impl_unittest.cc',

'offline_pages/offline_page_model_unittest.cc',

'offline_pages/snapshot_controller_unittest.cc',

@@ -992,7 +995,8 @@

'<@(mime_util_unittest_sources)',

'<@(network_time_unittest_sources)',

'<@(ntp_snippets_unittest_sources)',

- '<@(offline_page_unittest_sources)',

+ '<@(offline_pages_background_unittest_sources)',

+ '<@(offline_pages_unittest_sources)',

'<@(omnibox_unittest_sources)',

'<@(open_from_clipboard_unittest_sources)',

'<@(os_crypt_unittest_sources)',

@@ -1115,6 +1119,7 @@

'components.gyp:network_time',

'components.gyp:ntp_snippets',

'components.gyp:offline_pages',

+ 'components.gyp:offline_pages_background_offliner',

'components.gyp:offline_pages_test_support',

'components.gyp:omnibox_browser',

'components.gyp:omnibox_test_support',

« no previous file with comments | « components/BUILD.gn ('k') | components/offline_pages.gypi » ('j') | no next file with comments »