components/offline_pages/background/save_page_request.cc - Issue 1932953002: [Offline pages] Empty RequestQueue and SavePageRequest

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/offline_pages/background/save_page_request.cc

Issue 1932953002: [Offline pages] Empty RequestQueue and SavePageRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated with documentation and formatting Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/offline_pages/background/save_page_request.h"

	6

	7 namespace offline_pages {

	8

	9 SavePageRequest::SavePageRequest() {}
	Pete Williamson 2016/04/28 23:16:07 We don't need a Ctor and Dtor if we make this a st We don't need a Ctor and Dtor if we make this a struct, so maybe we can drop this file. fgorski 2016/04/29 05:19:16 I actually will want to construct it even when it Show quoted text On 2016/04/28 23:16:07, Pete Williamson wrote: > We don't need a Ctor and Dtor if we make this a struct, so maybe we can drop > this file. I actually will want to construct it even when it is a struct, to set reasonable values.
	10

	11 SavePageRequest::~SavePageRequest() {}

	12

	13 } // namespace offline_pages

	14

	15 #endif // COMPONENTS_OFFLINE_PAGES_BACKGROUND_SAVE_PAGE_REQUEST_H_

OLD	NEW

« components/offline_pages/background/save_page_request.h ('K') | « components/offline_pages/background/save_page_request.h ('k') | no next file » | no next file with comments »