Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Side by Side Diff: components/offline_pages/background/save_page_request_unittest.cc

Issue 1932953002: [Offline pages] Empty RequestQueue and SavePageRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nits from Pete Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/offline_pages/background/save_page_request.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "components/offline_pages/background/save_page_request.h"
6
7 #include "testing/gtest/include/gtest/gtest.h"
8
9 namespace offline_pages {
10
11 namespace {
12 const int64_t kRequestId = 42;
13 const GURL kUrl("http://example.com");
14 const ClientId kClientId("bookmark", "1234");
15 } // namespace
16
17 class SavePageRequestTest : public testing::Test {
18 public:
19 ~SavePageRequestTest() override;
20 };
21
22 SavePageRequestTest::~SavePageRequestTest() {}
23
24 TEST_F(SavePageRequestTest, CreatePendingReqeust) {
25 base::Time creation_time = base::Time::Now();
26 SavePageRequest request(kRequestId, kUrl, kClientId, creation_time);
27 ASSERT_EQ(kRequestId, request.request_id());
28 ASSERT_EQ(kUrl, request.url());
29 ASSERT_EQ(kClientId, request.client_id());
30 ASSERT_EQ(creation_time, request.creation_time());
31 ASSERT_EQ(creation_time, request.activation_time());
32 ASSERT_EQ(base::Time(), request.last_attempt_time());
33 ASSERT_EQ(0, request.attempt_count());
34
35 base::Time after_creation = creation_time + base::TimeDelta::FromHours(6);
36 ASSERT_EQ(SavePageRequest::Status::kPending,
37 request.GetStatus(after_creation));
38 }
39
40 TEST_F(SavePageRequestTest, CreateNotReadyRequest) {
41 base::Time creation_time = base::Time::Now();
42 base::Time activation_time = creation_time + base::TimeDelta::FromHours(6);
43 SavePageRequest request(kRequestId, kUrl, kClientId, creation_time,
44 activation_time);
45
46 ASSERT_EQ(kRequestId, request.request_id());
47 ASSERT_EQ(kUrl, request.url());
48 ASSERT_EQ(kClientId, request.client_id());
49 ASSERT_EQ(creation_time, request.creation_time());
50 ASSERT_EQ(activation_time, request.activation_time());
51 ASSERT_EQ(base::Time(), request.last_attempt_time());
52 ASSERT_EQ(0, request.attempt_count());
53
54 base::Time not_ready_time = activation_time - base::TimeDelta::FromHours(3);
55 ASSERT_EQ(SavePageRequest::Status::kNotReady,
56 request.GetStatus(not_ready_time));
57
58 base::Time ready_time = activation_time + base::TimeDelta::FromHours(3);
59 ASSERT_EQ(SavePageRequest::Status::kPending, request.GetStatus(ready_time));
60 }
61
62 TEST_F(SavePageRequestTest, StartAndCompleteRequest) {
63 base::Time creation_time = base::Time::Now();
64 base::Time activation_time = creation_time + base::TimeDelta::FromHours(6);
65 SavePageRequest request(kRequestId, kUrl, kClientId, creation_time,
66 activation_time);
67
68 base::Time start_time = activation_time + base::TimeDelta::FromHours(3);
69 request.MarkAttemptStarted(start_time);
70
71 // Most things don't change about the request.
72 ASSERT_EQ(kRequestId, request.request_id());
73 ASSERT_EQ(kUrl, request.url());
74 ASSERT_EQ(kClientId, request.client_id());
75 ASSERT_EQ(creation_time, request.creation_time());
76 ASSERT_EQ(activation_time, request.activation_time());
77
78 // Attempt time, attempt count and status will though.
79 ASSERT_EQ(start_time, request.last_attempt_time());
80 ASSERT_EQ(1, request.attempt_count());
81
82 ASSERT_EQ(SavePageRequest::Status::kStarted, request.GetStatus(start_time));
83
84 request.MarkAttemptCompleted();
85
86 // Again, most things don't change about the request.
87 ASSERT_EQ(kRequestId, request.request_id());
88 ASSERT_EQ(kUrl, request.url());
89 ASSERT_EQ(kClientId, request.client_id());
90 ASSERT_EQ(creation_time, request.creation_time());
91 ASSERT_EQ(activation_time, request.activation_time());
92
93 // Last attempt time and status will. Attempt count also unchanged.
94 ASSERT_EQ(base::Time(), request.last_attempt_time());
95 ASSERT_EQ(1, request.attempt_count());
96
97 ASSERT_EQ(SavePageRequest::Status::kPending, request.GetStatus(start_time));
98 }
99
100 } // offline_pages
OLDNEW
« no previous file with comments | « components/offline_pages/background/save_page_request.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698