Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1932903002: Add a flag for experimental native cups support (Closed)

Created:
4 years, 7 months ago by skau
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org, adlr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a flag for experimental native cups support BUG=chromium:607668 TEST=Running chrome with --enable-native-cups sets the flag in chrome://flags Committed: https://crrev.com/998fe7cd9108ee9e9bb48a5627fcf850a6ce2971 Cr-Commit-Position: refs/heads/master@{#391683}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Added metrics for the flag. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
rkaplow
can you also update the actions.xml. See the comment above on about_flags.cc for details
4 years, 7 months ago (2016-05-02 16:33:49 UTC) #4
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-02 19:15:49 UTC) #5
skau
On 2016/05/02 16:33:49, rkaplow wrote: > can you also update the actions.xml. See the comment ...
4 years, 7 months ago (2016-05-04 15:41:38 UTC) #6
rkaplow
lgtm
4 years, 7 months ago (2016-05-04 21:00:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932903002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932903002/60001
4 years, 7 months ago (2016-05-04 21:53:57 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-04 23:20:46 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 23:22:01 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/998fe7cd9108ee9e9bb48a5627fcf850a6ce2971
Cr-Commit-Position: refs/heads/master@{#391683}

Powered by Google App Engine
This is Rietveld 408576698