Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1932893004: Revert of Convert Widevine and Android platform key systems to KeySystemProperties (Closed)

Created:
4 years, 7 months ago by Justin Donnelly
Modified:
4 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, lcwu+watch_chromium.org, android-webview-reviews_chromium.org, halliwell+watch_chromium.org, eme-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert Widevine and Android platform key systems to KeySystemProperties (patchset #6 id:100001 of https://codereview.chromium.org/1926533002/ ) Reason for revert: Broke Google Chrome Mac bot. Original issue's description: > Convert Widevine and Android platform key systems to KeySystemProperties > > WidevineKeySystemProperties replaces the use of KeySystemInfo + > InfoBasedKeySystemProperties for widevine (logic is essentially copied). > Also updated Android platform key systems as it's simpler to convert the > APIs in android_key_systems together. > > BUG=457438 TBR=xhwang@chromium.org,michaelbai@chromium.org,sky@chromium.org,ddorwin@chromium.org,halliwell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457438 Committed: https://crrev.com/ee270d6ac0b30e5d7c028a849ccd96eb82581cab Cr-Commit-Position: refs/heads/master@{#390579}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -430 lines) Patch
M android_webview/renderer/aw_content_renderer_client.h View 1 chunk +1 line, -3 lines 0 comments Download
M android_webview/renderer/aw_content_renderer_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/renderer/aw_key_systems.h View 1 chunk +2 lines, -4 lines 0 comments Download
M android_webview/renderer/aw_key_systems.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/renderer/media/chrome_key_systems.h View 1 chunk +2 lines, -15 lines 0 comments Download
M chrome/renderer/media/chrome_key_systems.cc View 5 chunks +14 lines, -21 lines 0 comments Download
M chromecast/renderer/cast_content_renderer_client.h View 1 chunk +1 line, -4 lines 0 comments Download
M chromecast/renderer/cast_content_renderer_client.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M chromecast/renderer/key_systems_cast.h View 1 chunk +7 lines, -6 lines 0 comments Download
M chromecast/renderer/key_systems_cast.cc View 3 chunks +19 lines, -24 lines 0 comments Download
M components/cdm.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
M components/cdm/renderer/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M components/cdm/renderer/android_key_systems.h View 1 chunk +3 lines, -6 lines 0 comments Download
M components/cdm/renderer/android_key_systems.cc View 6 chunks +31 lines, -77 lines 0 comments Download
D components/cdm/renderer/widevine_key_system_properties.h View 1 chunk +0 lines, -66 lines 0 comments Download
D components/cdm/renderer/widevine_key_system_properties.cc View 1 chunk +0 lines, -176 lines 0 comments Download
A components/cdm/renderer/widevine_key_systems.h View 1 chunk +30 lines, -0 lines 0 comments Download
A components/cdm/renderer/widevine_key_systems.cc View 1 chunk +74 lines, -0 lines 0 comments Download
M media/base/key_system_properties.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Justin Donnelly
Created Revert of Convert Widevine and Android platform key systems to KeySystemProperties
4 years, 7 months ago (2016-04-29 02:41:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932893004/1
4 years, 7 months ago (2016-04-29 02:41:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 02:42:27 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:23:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee270d6ac0b30e5d7c028a849ccd96eb82581cab
Cr-Commit-Position: refs/heads/master@{#390579}

Powered by Google App Engine
This is Rietveld 408576698