Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 1932883002: Revert "[heap] Optimize NewSpace::AllocatedSinceLastGC" (Closed)

Created:
4 years, 7 months ago by Michael Lippautz
Modified:
4 years, 7 months ago
Reviewers:
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "[heap] Optimize NewSpace::AllocatedSinceLastGC" Also revert "[heap] Force inlining of AllocatedSinceLastGC" This is a speculative revert to see if it actually impacts the benchmarks in question. This reverts commit 723e120bd04aeb4da5b6b5e348cb5eaf28de5c48. This reverts commit 08dbdd4037aa612dc1afe40dbb073b3384b8a497. BUG=chromium:605524 LOG=N TBR=ulan@chromium.org Committed: https://crrev.com/5dc254f63b3c592c8e6c37b8012a5788fc45e5db Cr-Commit-Position: refs/heads/master@{#35881}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -39 lines) Patch
M src/heap/heap.h View 1 chunk +7 lines, -2 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/heap/spaces.h View 5 chunks +37 lines, -11 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932883002/1
4 years, 7 months ago (2016-04-28 20:36:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 21:08:45 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:03:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5dc254f63b3c592c8e6c37b8012a5788fc45e5db
Cr-Commit-Position: refs/heads/master@{#35881}

Powered by Google App Engine
This is Rietveld 408576698