Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1932873002: Remove "@informative" annotation on initializers and local functions. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove "@informative" annotation on initializers and local functions. Given code like this: var x = (...) => ...; The inferred type of x is the type of the closure, which is considered by analyzer to be a local function inside the inside the initializer expression (which is itself treated as a synthetic function for element model purposes). So we can't consider initializers and local functions to be "informative"; they can affect semantic via inferred types. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/dbde8085a15efc7d71eecfd43c8c1aa1fcfe89a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-04-28 20:33:04 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-04-28 20:34:27 UTC) #3
Paul Berry
4 years, 7 months ago (2016-04-28 20:38:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dbde8085a15efc7d71eecfd43c8c1aa1fcfe89a8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698