Add TraceProviderRegistry and implementation in tracing service/application.

Add TraceProviderRegistry and implementation in tracing service/application.

(To do separately: Update clients to use it, rather than the old way.)

R=jamesr@chromium.org
BUG=#763

Committed: https://chromium.googlesource.com/external/mojo/+/c667145bc39c20b2b68d5b3521fb94388c70da72

[jamesr, 2016-04-28 20:59:02]

lgtm

https://codereview.chromium.org/1932843002/diff/1/services/tracing/tracing_ap...
File services/tracing/tracing_app.cc (right):

https://codereview.chromium.org/1932843002/diff/1/services/tracing/tracing_ap...
services/tracing/tracing_app.cc:47: provider_registry_bindings_.AddBinding(this,
request.Pass());
at what point do we start saying std::move(request) instead of request.Pass() ?

[viettrungluu, 2016-04-28 21:37:57]

Thanks.

On 2016/04/28 20:59:02, jamesr wrote:
> lgtm
> 
>
https://codereview.chromium.org/1932843002/diff/1/services/tracing/tracing_ap...
> File services/tracing/tracing_app.cc (right):
> 
>
https://codereview.chromium.org/1932843002/diff/1/services/tracing/tracing_ap...
> services/tracing/tracing_app.cc:47:
provider_registry_bindings_.AddBinding(this,
> request.Pass());
> at what point do we start saying std::move(request) instead of request.Pass()
?

Dunno. Maybe, at some point I'll go through and change things en masse. In the
meantime, I guess it doesn't make a huge difference?

[jamesr, 2016-04-28 21:39:52]

On 2016/04/28 at 21:37:57, viettrungluu wrote:
> Dunno. Maybe, at some point I'll go through and change things en masse. In the
meantime, I guess it doesn't make a huge difference?

Not really, but if we want to get rid of the Pass() as some stage we'll want to
stop writing it in new stuff.

[viettrungluu, 2016-04-28 21:41:46]

Description was changed from

==========
Add TraceProviderRegistry and implementation in tracing service/application.

(To do separately: Update clients to use it, rather than the old way.)

R=jamesr@chromium.org
BUG=#763
==========

to

==========
Add TraceProviderRegistry and implementation in tracing service/application.

(To do separately: Update clients to use it, rather than the old way.)

R=jamesr@chromium.org
BUG=#763

Committed:
https://chromium.googlesource.com/external/mojo/+/c667145bc39c20b2b68d5b3521f...
==========

[viettrungluu, 2016-04-28 21:41:48]

Committed patchset #1 (id:1) manually as
c667145bc39c20b2b68d5b3521fb94388c70da72 (presubmit successful).