Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 193283002: Make ant failures easier to debug (Closed)

Created:
6 years, 9 months ago by cjhopman
Modified:
6 years, 9 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, Nico
Visibility:
Public.

Description

Make ant failures easier to debug Normally, ant commands (even when successful) have lots of useless output. So, for most of our ant commands we pass the -quiet flag. This is much better for successful builds but it makes debugging failures more difficult (though even without -quiet ant failures are difficult to diagnose without -verbose. So, the only way that ant failures are easy to debug is if the -verbose flag is passed to ant. This flag is much too noisy to always pass. This change makes it so that if a call to ant fails, we repeat that call with the -verbose flag (and without -quiet) so that the output that the developer sees is most useful. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256179

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M build/android/gyp/ant.py View 2 chunks +21 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cjhopman
newt: *
6 years, 9 months ago (2014-03-10 21:24:03 UTC) #1
newt (away)
lgtm. I'm a bit concerned though about the lack of exponential backoff.
6 years, 9 months ago (2014-03-10 22:43:13 UTC) #2
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 9 months ago (2014-03-10 23:41:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/193283002/1
6 years, 9 months ago (2014-03-11 00:22:28 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 10:16:50 UTC) #5
Message was sent while issue was closed.
Change committed as 256179

Powered by Google App Engine
This is Rietveld 408576698