Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2038)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1932803002: Add a BoringSSL builder for OPENSSL_NO_THREADS. (Closed)

Created:
4 years, 7 months ago by davidben
Modified:
4 years, 7 months ago
Reviewers:
svaldez
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add a BoringSSL builder for OPENSSL_NO_THREADS. BUG=boringssl:51 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300292

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M masters/master.client.boringssl/master.cfg View 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.client.boringssl/slaves.cfg View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/boringssl.py View 2 chunks +4 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/boringssl.expected/linux_nothreads.json View 2 chunks +3 lines, -2 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
davidben
Here you go.
4 years, 7 months ago (2016-04-28 18:17:13 UTC) #2
svaldez
lgtm https://codereview.chromium.org/1932803002/diff/1/scripts/slave/recipes/boringssl.expected/linux_nothreads.json File scripts/slave/recipes/boringssl.expected/linux_nothreads.json (right): https://codereview.chromium.org/1932803002/diff/1/scripts/slave/recipes/boringssl.expected/linux_nothreads.json#newcode109 scripts/slave/recipes/boringssl.expected/linux_nothreads.json:109: "-DCMAKE_CXX_FLAGS=-DOPENSSL_NO_THREADS=1", Can you just use C_CXX_FLAGS?
4 years, 7 months ago (2016-04-28 18:36:58 UTC) #3
davidben
https://codereview.chromium.org/1932803002/diff/1/scripts/slave/recipes/boringssl.expected/linux_nothreads.json File scripts/slave/recipes/boringssl.expected/linux_nothreads.json (right): https://codereview.chromium.org/1932803002/diff/1/scripts/slave/recipes/boringssl.expected/linux_nothreads.json#newcode109 scripts/slave/recipes/boringssl.expected/linux_nothreads.json:109: "-DCMAKE_CXX_FLAGS=-DOPENSSL_NO_THREADS=1", On 2016/04/28 18:36:58, svaldez wrote: > Can you ...
4 years, 7 months ago (2016-04-28 18:46:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932803002/1
4 years, 7 months ago (2016-04-28 18:46:19 UTC) #6
svaldez
On 2016/04/28 18:46:04, davidben wrote: > https://codereview.chromium.org/1932803002/diff/1/scripts/slave/recipes/boringssl.expected/linux_nothreads.json > File scripts/slave/recipes/boringssl.expected/linux_nothreads.json (right): > > https://codereview.chromium.org/1932803002/diff/1/scripts/slave/recipes/boringssl.expected/linux_nothreads.json#newcode109 > ...
4 years, 7 months ago (2016-04-28 18:46:35 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-28 18:51:15 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300292

Powered by Google App Engine
This is Rietveld 408576698