Figure out the MIME type of shared WebUI resources more efficiently

Figure out the MIME type of shared WebUI resources more efficiently

Previously, GetMimeType() was posted to run on UI thread and potentially
hit disk on Posix systems.

This CL fixes both by adding a hardcoded list (based on `find` scraping)
and requesting GetMimeType() be run from the originating thread (IO)
rather than posting to UI.

R=groby@chromium.org
BUG=608078
Committed: https://crrev.com/8678179613c967ec865b8ee7d1abd9427bd27233
Cr-Commit-Position: refs/heads/master@{#390843}

[Dan Beam, 2016-04-29 22:36:41]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2016-04-29 22:39:36]

https://codereview.chromium.org/1932753006/diff/20001/content/browser/webui/s...
File content/browser/webui/shared_resources_data_source.cc (right):

https://codereview.chromium.org/1932753006/diff/20001/content/browser/webui/s...
content/browser/webui/shared_resources_data_source.cc:110: if
(filepath.MatchesExtension(".html"))
list derived via magic

(`find ui/webui/resources/ ui/views/resources/default_*00_percent/common/
third_party/polymer/v1_0/components-chromium/ -type f | grep -o '\..*$' | sort |
uniq | grep -v gyp | grep -v grd | grep -v gtest | grep -v externs | grep -v
txt`)

[groby-ooo-7-16, 2016-04-29 23:39:16]

LGTM w/ a few questions.

https://codereview.chromium.org/1932753006/diff/20001/content/browser/webui/s...
File content/browser/webui/shared_resources_data_source.cc (right):

https://codereview.chromium.org/1932753006/diff/20001/content/browser/webui/s...
content/browser/webui/shared_resources_data_source.cc:105: const std::string&
path) const {
I still fail to understand why we couldn't run this on the IO thread right away.
As far as I can tell, StartDataRequest is thread-agnostic, which means we could
just return nullptr  MessageLoopForRequestPath

https://codereview.chromium.org/1932753006/diff/20001/content/browser/webui/s...
content/browser/webui/shared_resources_data_source.cc:109: base::FilePath
filepath(path);
I'd minimally prefer getting the extension once (path.Extension()) and then
compare, but not enough to make you do it unless you're bored :)

https://codereview.chromium.org/1932753006/diff/20001/content/browser/webui/s...
content/browser/webui/shared_resources_data_source.cc:131: NOTREACHED();
You want to do a CHECK here to force people to notice?

[Dan Beam, 2016-04-30 00:32:22]

Patchset #2 (id:40001) has been deleted

[Dan Beam, 2016-04-30 00:32:34]

https://codereview.chromium.org/1932753006/diff/20001/content/browser/webui/s...
File content/browser/webui/shared_resources_data_source.cc (right):

https://codereview.chromium.org/1932753006/diff/20001/content/browser/webui/s...
content/browser/webui/shared_resources_data_source.cc:105: const std::string&
path) const {
On 2016/04/29 23:39:15, groby wrote:
> I still fail to understand why we couldn't run this on the IO thread right
away.
> As far as I can tell, StartDataRequest is thread-agnostic, which means we
could
> just return nullptr  MessageLoopForRequestPath
> 

Done.

https://codereview.chromium.org/1932753006/diff/20001/content/browser/webui/s...
content/browser/webui/shared_resources_data_source.cc:109: base::FilePath
filepath(path);
On 2016/04/29 23:39:16, groby wrote:
> I'd minimally prefer getting the extension once (path.Extension()) and then
> compare, but not enough to make you do it unless you're bored :)

Done.

https://codereview.chromium.org/1932753006/diff/20001/content/browser/webui/s...
content/browser/webui/shared_resources_data_source.cc:131: NOTREACHED();
On 2016/04/29 23:39:15, groby wrote:
> You want to do a CHECK here to force people to notice?

Done.

[Dan Beam, 2016-04-30 00:35:25]

Description was changed from

==========
Skips going to disk just to get the MIME type of shared resources

R=groby@chromium.org
BUG=608078
==========

to

==========
Figure out the MIME type of shared WebUI resources more efficiently

Previously, GetMimeType() was posted to run on UI thread and potentially hit
disk on Posix systems.

This CL fixes both by adding a hardcoded list (based on `find` scraping) and
requesting GetMimeType() be run from the originating thread (IO) rather than
posting to UI.

R=groby@chromium.org
BUG=608078
==========

[Dan Beam, 2016-04-30 00:36:28]

Description was changed from

==========
Figure out the MIME type of shared WebUI resources more efficiently

Previously, GetMimeType() was posted to run on UI thread and potentially hit
disk on Posix systems.

This CL fixes both by adding a hardcoded list (based on `find` scraping) and
requesting GetMimeType() be run from the originating thread (IO) rather than
posting to UI.

R=groby@chromium.org
BUG=608078
==========

to

==========
Figure out the MIME type of shared WebUI resources more efficiently

Previously, GetMimeType() was posted to run on UI thread and potentially
hit disk on Posix systems.

This CL fixes both by adding a hardcoded list (based on `find` scraping)        
                                                   
and requesting GetMimeType() be run from the originating thread (IO)
rather than posting to UI.
==========

[Dan Beam, 2016-04-30 00:36:59]

Description was changed from

==========
Figure out the MIME type of shared WebUI resources more efficiently

Previously, GetMimeType() was posted to run on UI thread and potentially
hit disk on Posix systems.

This CL fixes both by adding a hardcoded list (based on `find` scraping)        
                                                   
and requesting GetMimeType() be run from the originating thread (IO)
rather than posting to UI.
==========

to

==========
Figure out the MIME type of shared WebUI resources more efficiently

Previously, GetMimeType() was posted to run on UI thread and potentially
hit disk on Posix systems.

This CL fixes both by adding a hardcoded list (based on `find` scraping)        
                                                   
and requesting GetMimeType() be run from the originating thread (IO)
rather than posting to UI.

R=groby@chromium.org
BUG=608078
==========

[Dan Beam, 2016-04-30 02:22:02]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-04-30 02:22:02]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org
Link to the patchset: https://codereview.chromium.org/1932753006/#ps80001
(title: "asdf")

[commit-bot: I haz the power, 2016-04-30 02:22:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1932753006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1932753006/80001

[commit-bot: I haz the power, 2016-04-30 03:26:36]

Description was changed from

==========
Figure out the MIME type of shared WebUI resources more efficiently

Previously, GetMimeType() was posted to run on UI thread and potentially
hit disk on Posix systems.

This CL fixes both by adding a hardcoded list (based on `find` scraping)        
                                                   
and requesting GetMimeType() be run from the originating thread (IO)
rather than posting to UI.

R=groby@chromium.org
BUG=608078
==========

to

==========
Figure out the MIME type of shared WebUI resources more efficiently

Previously, GetMimeType() was posted to run on UI thread and potentially
hit disk on Posix systems.

This CL fixes both by adding a hardcoded list (based on `find` scraping)        
                                                   
and requesting GetMimeType() be run from the originating thread (IO)
rather than posting to UI.

R=groby@chromium.org
BUG=608078
==========

[commit-bot: I haz the power, 2016-04-30 03:26:37]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-04-30 17:31:07]

Patchset 3 (id:??) landed as
https://crrev.com/8678179613c967ec865b8ee7d1abd9427bd27233
Cr-Commit-Position: refs/heads/master@{#390843}

[commit-bot: I haz the power, 2016-04-30 18:04:06]

Description was changed from

==========
Figure out the MIME type of shared WebUI resources more efficiently

Previously, GetMimeType() was posted to run on UI thread and potentially
hit disk on Posix systems.

This CL fixes both by adding a hardcoded list (based on `find` scraping)        
                                                   
and requesting GetMimeType() be run from the originating thread (IO)
rather than posting to UI.

R=groby@chromium.org
BUG=608078
==========

to

==========
Figure out the MIME type of shared WebUI resources more efficiently

Previously, GetMimeType() was posted to run on UI thread and potentially
hit disk on Posix systems.

This CL fixes both by adding a hardcoded list (based on `find` scraping)
and requesting GetMimeType() be run from the originating thread (IO)
rather than posting to UI.

R=groby@chromium.org
BUG=608078

Committed: https://crrev.com/8678179613c967ec865b8ee7d1abd9427bd27233
Cr-Commit-Position: refs/heads/master@{#390843}
==========