Download Malware blacklist on desktop platforms.

Download Malware blacklist on desktop platforms.
This is currently hard-coded but should come from the Database, when that gets implemented.
Filed issue http://crbug.com/608075 to track removing this.

The clients that are opted-in are Finch controlled.
See: http://crrev.com/1924983002

+ Also corrected some dependencies in BUILD.gn and .gypi
+ Also added some useful some debug logs and removed some not-so-useful ones.

BUG=543161
Committed: https://crrev.com/b962d1fa0e53268388392b193a913e2e63d7b25b
Cr-Commit-Position: refs/heads/master@{#391327}

[vakh (use Gerrit instead), 2016-04-29 22:24:26]

Description was changed from

==========
Download Malware blacklist on desktop platforms.

The clients that are opted-in are Finch controlled.
See: http://crrev.com/1924983002

BUG=543161
==========

to

==========
Download Malware blacklist on desktop platforms.
This is currently hard-coded but should come from the Database, when that gets
implemented.
Filed issue 608075 to track removing this.

The clients that are opted-in are Finch controlled.
See: http://crrev.com/1924983002

+ Also corrected some dependencies in BUILD.gn and .gypi
+ Also added some useful some debug logs and removed some not-so-useful ones.

BUG=543161
==========

[vakh (use Gerrit instead), 2016-04-29 22:24:26]

vakh@chromium.org changed reviewers:
+ nparker@chromium.org

[vakh (use Gerrit instead), 2016-04-29 22:29:00]

Description was changed from

==========
Download Malware blacklist on desktop platforms.
This is currently hard-coded but should come from the Database, when that gets
implemented.
Filed issue 608075 to track removing this.

The clients that are opted-in are Finch controlled.
See: http://crrev.com/1924983002

+ Also corrected some dependencies in BUILD.gn and .gypi
+ Also added some useful some debug logs and removed some not-so-useful ones.

BUG=543161
==========

to

==========
Download Malware blacklist on desktop platforms.
This is currently hard-coded but should come from the Database, when that gets
implemented.
Filed issue http://crbug.com/608075 to track removing this.

The clients that are opted-in are Finch controlled.
See: http://crrev.com/1924983002

+ Also corrected some dependencies in BUILD.gn and .gypi
+ Also added some useful some debug logs and removed some not-so-useful ones.

BUG=543161
==========

[vakh (use Gerrit instead), 2016-04-29 22:30:15]

Add link to bug

[Nathan Parker, 2016-04-30 00:16:49]

lgtm

https://codereview.chromium.org/1932753005/diff/20001/components/safe_browsin...
File components/safe_browsing_db/v4_local_database_manager.cc (right):

https://codereview.chromium.org/1932753005/diff/20001/components/safe_browsin...
components/safe_browsing_db/v4_local_database_manager.cc:150: #elif defined
(OS_LINUX)
I think OS_LINUX _include_ chromeos (I don't know why).  Should we separate
them?

e.g.
https://code.google.com/p/chromium/codesearch#search/&q=os_linux.*chrome&sq=p...

[vakh (use Gerrit instead), 2016-04-30 00:18:38]

https://codereview.chromium.org/1932753005/diff/20001/components/safe_browsin...
File components/safe_browsing_db/v4_local_database_manager.cc (right):

https://codereview.chromium.org/1932753005/diff/20001/components/safe_browsin...
components/safe_browsing_db/v4_local_database_manager.cc:150: #elif defined
(OS_LINUX)
On 2016/04/30 00:16:49, Nathan Parker wrote:
> I think OS_LINUX _include_ chromeos (I don't know why).  Should we separate
> them?
> 
> e.g.
>
https://code.google.com/p/chromium/codesearch#search/&q=os_linux.*chrome&sq=p...

There's no separate Enum value for ChromeOS so I think this is perfect :)
https://code.google.com/p/chromium/codesearch#chromium/src/components/safe_br...

[vakh (use Gerrit instead), 2016-04-30 00:53:51]

git pull

[vakh (use Gerrit instead), 2016-05-03 18:24:16]

git pull

[vakh (use Gerrit instead), 2016-05-03 18:24:45]

The CQ bit was checked by vakh@chromium.org

[vakh (use Gerrit instead), 2016-05-03 18:24:46]

The patchset sent to the CQ was uploaded after l-g-t-m from nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/1932753005/#ps60001
(title: "git pull")

[commit-bot: I haz the power, 2016-05-03 18:25:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1932753005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1932753005/60001

[commit-bot: I haz the power, 2016-05-03 19:30:43]

Description was changed from

==========
Download Malware blacklist on desktop platforms.
This is currently hard-coded but should come from the Database, when that gets
implemented.
Filed issue http://crbug.com/608075 to track removing this.

The clients that are opted-in are Finch controlled.
See: http://crrev.com/1924983002

+ Also corrected some dependencies in BUILD.gn and .gypi
+ Also added some useful some debug logs and removed some not-so-useful ones.

BUG=543161
==========

to

==========
Download Malware blacklist on desktop platforms.
This is currently hard-coded but should come from the Database, when that gets
implemented.
Filed issue http://crbug.com/608075 to track removing this.

The clients that are opted-in are Finch controlled.
See: http://crrev.com/1924983002

+ Also corrected some dependencies in BUILD.gn and .gypi
+ Also added some useful some debug logs and removed some not-so-useful ones.

BUG=543161
==========

[commit-bot: I haz the power, 2016-05-03 19:30:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-03 19:32:10]

Description was changed from

==========
Download Malware blacklist on desktop platforms.
This is currently hard-coded but should come from the Database, when that gets
implemented.
Filed issue http://crbug.com/608075 to track removing this.

The clients that are opted-in are Finch controlled.
See: http://crrev.com/1924983002

+ Also corrected some dependencies in BUILD.gn and .gypi
+ Also added some useful some debug logs and removed some not-so-useful ones.

BUG=543161
==========

to

==========
Download Malware blacklist on desktop platforms.
This is currently hard-coded but should come from the Database, when that gets
implemented.
Filed issue http://crbug.com/608075 to track removing this.

The clients that are opted-in are Finch controlled.
See: http://crrev.com/1924983002

+ Also corrected some dependencies in BUILD.gn and .gypi
+ Also added some useful some debug logs and removed some not-so-useful ones.

BUG=543161

Committed: https://crrev.com/b962d1fa0e53268388392b193a913e2e63d7b25b
Cr-Commit-Position: refs/heads/master@{#391327}
==========

[commit-bot: I haz the power, 2016-05-03 19:32:12]

Patchset 4 (id:??) landed as
https://crrev.com/b962d1fa0e53268388392b193a913e2e63d7b25b
Cr-Commit-Position: refs/heads/master@{#391327}