Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1932743002: Delete unused code from SkColorSpace (Closed)

Created:
4 years, 7 months ago by msarett
Modified:
4 years, 7 months ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@improveparsing
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Delete unused code from SkColorSpace IMO, a lot of this code reflects an oversimplified view of handling color profiles. And a lot of this code is valid math/checks/enums that we will eventually need. Right now, it's all unused and is adding a bit of clutter and confusion as I try to redesign this object. I think it makes sense to start simpler and build this back up as necessary. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1932743002 Committed: https://skia.googlesource.com/skia/+/23bd7e9273438863149ed58c089e9bf457e9892d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -214 lines) Patch
M src/core/SkColorSpace.h View 2 chunks +0 lines, -19 lines 0 comments Download
M src/core/SkColorSpace.cpp View 5 chunks +1 line, -195 lines 1 comment Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
msarett
This may be a bit aggressive. In that case, the git history will save me ...
4 years, 7 months ago (2016-04-28 15:03:25 UTC) #4
reed1
lgtm
4 years, 7 months ago (2016-04-28 15:40:56 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932743002/1
4 years, 7 months ago (2016-04-28 16:36:56 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-28 16:48:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932743002/1
4 years, 7 months ago (2016-04-28 16:49:16 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-04-28 16:50:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/23bd7e9273438863149ed58c089e9bf457e9892d

Powered by Google App Engine
This is Rietveld 408576698