Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1932733003: [tracing] Don't use moved value. (Closed)

Created:
4 years, 7 months ago by Dmitry Skiba
Modified:
4 years, 7 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Don't use moved value. This CL fixes an issue where we use std::unique_ptr<> after explicitly moving it into a map. Committed: https://crrev.com/d20680c83c603d50678a6be1e1f389c25783ea86 Cr-Commit-Position: refs/heads/master@{#390745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M base/trace_event/process_memory_dump.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Dmitry Skiba
4 years, 7 months ago (2016-04-28 16:16:48 UTC) #2
Primiano Tucci (use gerrit)
bug in the dcheck, LOL Thanks for fixing this. No need for a BUG, but ...
4 years, 7 months ago (2016-04-29 11:57:09 UTC) #3
Primiano Tucci (use gerrit)
ehm I also meant LGTM :)
4 years, 7 months ago (2016-04-29 11:57:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932733003/1
4 years, 7 months ago (2016-04-29 19:34:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 20:41:02 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:28:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d20680c83c603d50678a6be1e1f389c25783ea86
Cr-Commit-Position: refs/heads/master@{#390745}

Powered by Google App Engine
This is Rietveld 408576698