Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: mojo/nacl/nonsfi/irt_pnacl_translator_compile.cc

Issue 1932713003: More SynchronousInterfacePtr conversion + some related pexe content handler cleanup. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | services/http_server/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/nacl/nonsfi/irt_pnacl_translator_compile.cc
diff --git a/mojo/nacl/nonsfi/irt_pnacl_translator_compile.cc b/mojo/nacl/nonsfi/irt_pnacl_translator_compile.cc
index 77a7ef880dd0fac80a235631fd6c0a7e1dea62b1..37d9426b49506537214b50ee96861ae404bed8bb 100644
--- a/mojo/nacl/nonsfi/irt_pnacl_translator_compile.cc
+++ b/mojo/nacl/nonsfi/irt_pnacl_translator_compile.cc
@@ -21,9 +21,10 @@ namespace {
// with the nexe compiler service.
class PexeCompilerImpl : public mojo::nacl::PexeCompiler {
public:
- PexeCompilerImpl(mojo::ScopedMessagePipeHandle handle,
- const struct nacl_irt_pnacl_compile_funcs* funcs)
- : funcs_(funcs), strong_binding_(this, handle.Pass()) {}
+ PexeCompilerImpl(
+ mojo::InterfaceRequest<mojo::nacl::PexeCompiler> compiler_request,
+ const struct nacl_irt_pnacl_compile_funcs* funcs)
+ : funcs_(funcs), strong_binding_(this, compiler_request.Pass()) {}
void PexeCompile(const mojo::String& pexe_file_name, const
mojo::Callback<void(mojo::Array<mojo::String>)>& callback)
override {
@@ -117,7 +118,8 @@ void ServeTranslateRequest(const struct nacl_irt_pnacl_compile_funcs* funcs) {
// Convert the MojoHandle into a ScopedMessagePipeHandle, and use that to
// implement the PexeCompiler interface.
PexeCompilerImpl impl(
- mojo::ScopedMessagePipeHandle(mojo::MessagePipeHandle(handle)).Pass(),
+ mojo::MakeRequest<mojo::nacl::PexeCompiler>(
+ mojo::ScopedMessagePipeHandle(mojo::MessagePipeHandle(handle))),
funcs);
mojo::RunLoop::current()->Run();
}
« no previous file with comments | « no previous file | services/http_server/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698