Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1932713003: More SynchronousInterfacePtr conversion + some related pexe content handler cleanup. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan, Sean Klein
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

More SynchronousInterfacePtr conversion + some related pexe content handler cleanup. R=smklein@chromium.org, vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/fe25adb16a0b0c7eb4b377d37db2844538b309a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -112 lines) Patch
M mojo/nacl/nonsfi/irt_pnacl_translator_compile.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M services/http_server/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M services/http_server/http_server_apptest.cc View 8 chunks +26 lines, -20 lines 0 comments Download
M services/nacl/nonsfi/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/nacl/nonsfi/content_handler_main_pexe.cc View 4 chunks +14 lines, -68 lines 0 comments Download
M services/nacl/nonsfi/pnacl_compile.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M services/nacl/nonsfi/pnacl_compile.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/nacl/nonsfi/pnacl_link.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M services/nacl/nonsfi/pnacl_link.mojom View 1 chunk +1 line, -1 line 0 comments Download
M shell/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M shell/shell_apptest.cc View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
vardhan -> SynchronousInterfacePtr conversion stuff smklein -> pnacl stuff
4 years, 7 months ago (2016-04-28 17:08:01 UTC) #1
vardhan
shell_apptest & http_server_apptest lgtm
4 years, 7 months ago (2016-04-28 17:16:26 UTC) #2
Sean Klein
LGTM. Thanks! This makes that NaCl code much cleaner.
4 years, 7 months ago (2016-04-28 17:26:32 UTC) #3
viettrungluu
4 years, 7 months ago (2016-04-28 17:33:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
fe25adb16a0b0c7eb4b377d37db2844538b309a7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698