Skia GN build.

Skia GN build.

This Cl makes GN execute correctly for builds with pdf_use_skia=true enabled.

BUG=pdfium:487
Committed: https://pdfium.googlesource.com/pdfium/+/11988d7b8528d52a0da78ca2be47402e9d09a913

[dsinclair, 2016-04-28 17:12:26]

dsinclair@chromium.org changed reviewers:
+ caryclark@chromium.org, thakis@chromium.org, thestig@chromium.org

[dsinclair, 2016-04-28 17:12:27]

PTAL.

I had to add generate_library_loaders because I started getting:

ERROR at //build/linux/BUILD.gn:7:1: Can't load input file.
import("//tools/generate_library_loader/generate_library_loader.gni")
^-------------------------------------------------------------------
 

Which forced me to add the libudev third_party code due to:

In file included from gen/library_loaders/libudev1_loader.cc:4:
../../out/Debug/gen/library_loaders/libudev1.h:7:10: fatal error:
'third_party/libudev/libudev1.h' file not found
#include "third_party/libudev/libudev1.h"
         ^

This lets the build run, although it fails due to three warnings treated as
errors in the Skia code.

[caryclark, 2016-04-28 19:52:04]

> This lets the build run, although it fails due to three warnings treated as
> errors in the Skia code.

Those warnings don't appear on Mac or Windows but do appear on Linux.
I saw them today myself. I'll submit a CL tomorrow to get rid of them.

[Lei Zhang, 2016-04-28 20:04:28]

Can we talk to the GN folks about this? We don't even use libudev in PDFium
AFAIK.

[dsinclair, 2016-05-02 17:17:20]

On 2016/04/28 20:04:28, Lei Zhang wrote:
> Can we talk to the GN folks about this? We don't even use libudev in PDFium
> AFAIK.

Nico, any suggestions on how to fix the libudev issue?


Without the generate_library_loader DEPS entry I get:

Development/pdfium/pdfium % gn gen out/Debug
ERROR at //build/linux/BUILD.gn:7:1: Can't load input file.
import("//tools/generate_library_loader/generate_library_loader.gni")
^-------------------------------------------------------------------


Without the third_party/libudev files:

In file included from gen/library_loaders/libudev0_loader.cc:4:
../../out/Debug/gen/library_loaders/libudev0.h:7:10: fatal error:
'third_party/libudev/libudev0.h' file not found
#include "third_party/libudev/libudev0.h"


In file included from gen/library_loaders/libudev1_loader.cc:4:
../../out/Debug/gen/library_loaders/libudev1.h:7:10: fatal error:
'third_party/libudev/libudev1.h' file not found
#include "third_party/libudev/libudev1.h"

[Nico, 2016-05-02 17:18:38]

On 2016/05/02 17:17:20, dsinclair wrote:
> On 2016/04/28 20:04:28, Lei Zhang wrote:
> > Can we talk to the GN folks about this? We don't even use libudev in PDFium
> > AFAIK.
> 
> Nico, any suggestions on how to fix the libudev issue?

I don't know. Ask on gn-dev?

> 
> 
> Without the generate_library_loader DEPS entry I get:
> 
> Development/pdfium/pdfium % gn gen out/Debug
> ERROR at //build/linux/BUILD.gn:7:1: Can't load input file.
> import("//tools/generate_library_loader/generate_library_loader.gni")
> ^-------------------------------------------------------------------
> 
> 
> Without the third_party/libudev files:
> 
> In file included from gen/library_loaders/libudev0_loader.cc:4:
> ../../out/Debug/gen/library_loaders/libudev0.h:7:10: fatal error:
> 'third_party/libudev/libudev0.h' file not found
> #include "third_party/libudev/libudev0.h"
> 
> 
> In file included from gen/library_loaders/libudev1_loader.cc:4:
> ../../out/Debug/gen/library_loaders/libudev1.h:7:10: fatal error:
> 'third_party/libudev/libudev1.h' file not found
> #include "third_party/libudev/libudev1.h"

[dsinclair, 2016-05-03 15:30:17]

On 2016/05/02 17:18:38, Nico wrote:
> On 2016/05/02 17:17:20, dsinclair wrote:
> > On 2016/04/28 20:04:28, Lei Zhang wrote:
> > > Can we talk to the GN folks about this? We don't even use libudev in
PDFium
> > > AFAIK.
> > 
> > Nico, any suggestions on how to fix the libudev issue?
> 
> I don't know. Ask on gn-dev?
> 
> > 
> > 
> > Without the generate_library_loader DEPS entry I get:
> > 
> > Development/pdfium/pdfium % gn gen out/Debug
> > ERROR at //build/linux/BUILD.gn:7:1: Can't load input file.
> > import("//tools/generate_library_loader/generate_library_loader.gni")
> > ^-------------------------------------------------------------------
> > 
> > 
> > Without the third_party/libudev files:
> > 
> > In file included from gen/library_loaders/libudev0_loader.cc:4:
> > ../../out/Debug/gen/library_loaders/libudev0.h:7:10: fatal error:
> > 'third_party/libudev/libudev0.h' file not found
> > #include "third_party/libudev/libudev0.h"
> > 
> > 
> > In file included from gen/library_loaders/libudev1_loader.cc:4:
> > ../../out/Debug/gen/library_loaders/libudev1.h:7:10: fatal error:
> > 'third_party/libudev/libudev1.h' file not found
> > #include "third_party/libudev/libudev1.h"


It sounds like the fix on the Chromium side is to break apart headers to make
things work. Do we want to wait for chromium to get that work done? If so, we'll
have to maintain the GYP build until that point.

[dsinclair, 2016-05-03 20:49:35]

On 2016/05/03 15:30:17, dsinclair wrote:
> On 2016/05/02 17:18:38, Nico wrote:
> > On 2016/05/02 17:17:20, dsinclair wrote:
> > > On 2016/04/28 20:04:28, Lei Zhang wrote:
> > > > Can we talk to the GN folks about this? We don't even use libudev in
> PDFium
> > > > AFAIK.
> > > 
> > > Nico, any suggestions on how to fix the libudev issue?
> > 
> > I don't know. Ask on gn-dev?
> > 
> > > 
> > > 
> > > Without the generate_library_loader DEPS entry I get:
> > > 
> > > Development/pdfium/pdfium % gn gen out/Debug
> > > ERROR at //build/linux/BUILD.gn:7:1: Can't load input file.
> > > import("//tools/generate_library_loader/generate_library_loader.gni")
> > > ^-------------------------------------------------------------------
> > > 
> > > 
> > > Without the third_party/libudev files:
> > > 
> > > In file included from gen/library_loaders/libudev0_loader.cc:4:
> > > ../../out/Debug/gen/library_loaders/libudev0.h:7:10: fatal error:
> > > 'third_party/libudev/libudev0.h' file not found
> > > #include "third_party/libudev/libudev0.h"
> > > 
> > > 
> > > In file included from gen/library_loaders/libudev1_loader.cc:4:
> > > ../../out/Debug/gen/library_loaders/libudev1.h:7:10: fatal error:
> > > 'third_party/libudev/libudev1.h' file not found
> > > #include "third_party/libudev/libudev1.h"
> 
> 
> It sounds like the fix on the Chromium side is to break apart headers to make
> things work. Do we want to wait for chromium to get that work done? If so,
we'll
> have to maintain the GYP build until that point.

Chromium side change is up for review at:
https://codereview.chromium.org/1945893002/ once that lands I can roll //build
(and //buildtools I believe) and this should be good to go.

[dsinclair, 2016-05-04 15:44:02]

PTAL. The chromium change has landed and DEPS updated.

[caryclark, 2016-05-04 16:18:28]

caryclark@google.com changed reviewers:
+ caryclark@google.com

[caryclark, 2016-05-04 16:18:28]

lgtm

It's unfortunate that skia/BUILD.gn is a near-copy of another file -- if minor
edits are made to the original, they won't get reflected in the copy. That may
not be important while we're in the bring-up stage so I won't worry about it.

[dsinclair, 2016-05-04 17:04:43]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-05-04 17:04:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1932683003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1932683003/60001

[commit-bot: I haz the power, 2016-05-04 17:17:03]

Description was changed from

==========
Skia GN build.

This Cl makes GN execute correctly for builds with pdf_use_skia=true enabled.

BUG=pdfium:487
==========

to

==========
Skia GN build.

This Cl makes GN execute correctly for builds with pdf_use_skia=true enabled.

BUG=pdfium:487

Committed:
https://pdfium.googlesource.com/pdfium/+/11988d7b8528d52a0da78ca2be47402e9d09...
==========

[commit-bot: I haz the power, 2016-05-04 17:17:04]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/11988d7b8528d52a0da78ca2be47402e9d09...