Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1932673002: querySelector* fast-path missing namespace check for no namespace. (Closed)

Created:
4 years, 7 months ago by rune
Modified:
4 years, 7 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

querySelector* fast-path missing namespace check for no namespace. querySelector* does not allow selectors with namespaces, yet selectors with no namespace are still allowed. Check for empty namespace before hitting the fast path for tag names. R=esprehn@chromium.org BUG=605502 Committed: https://crrev.com/f0e4bdb8bdd9f2eb306b1ffc29e881c0cc258794 Cr-Commit-Position: refs/heads/master@{#390417}

Patch Set 1 #

Patch Set 2 : Compile fix #

Patch Set 3 : nullAtom not emptyAtom #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/SelectorAPI/namespaced-elements-and-selectors.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/SelectorAPI/namespaced-elements-and-selectors-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SelectorQuery.cpp View 1 2 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932673002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932673002/40001
4 years, 7 months ago (2016-04-28 10:39:40 UTC) #2
rune
First, I added a check for no namespace in the fast-path matchesTagName, but since this ...
4 years, 7 months ago (2016-04-28 11:11:31 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-28 11:49:40 UTC) #5
esprehn
Lgtm, thanks for the quick fix!
4 years, 7 months ago (2016-04-28 15:22:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932673002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932673002/40001
4 years, 7 months ago (2016-04-28 17:39:26 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-28 17:46:46 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:19:29 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f0e4bdb8bdd9f2eb306b1ffc29e881c0cc258794
Cr-Commit-Position: refs/heads/master@{#390417}

Powered by Google App Engine
This is Rietveld 408576698