Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 1932663002: Turn sliced strings into flat cons-strings upon internalization (Closed)

Created:
4 years, 7 months ago by Toon Verwaest
Modified:
4 years, 7 months ago
Reviewers:
ulan, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turn sliced strings into flat cons-strings upon internalization Flat cons-strings point directly to the internalized version of the string. This makes reinternalization much faster. BUG= Committed: https://crrev.com/b7be3cf551dbc19bca321ddf0ad5ff0946a6c962 Cr-Commit-Position: refs/heads/master@{#35852}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/objects.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Toon Verwaest
ptal
4 years, 7 months ago (2016-04-28 08:43:31 UTC) #2
Yang
On 2016/04/28 08:43:31, Toon Verwaest wrote: > ptal lgtm.
4 years, 7 months ago (2016-04-28 08:47:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932663002/1
4 years, 7 months ago (2016-04-28 09:32:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 10:09:06 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:02:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7be3cf551dbc19bca321ddf0ad5ff0946a6c962
Cr-Commit-Position: refs/heads/master@{#35852}

Powered by Google App Engine
This is Rietveld 408576698