Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 1932653003: Refresh LocalDOMWindow post-Oilpan. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
haraken, dcheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refresh LocalDOMWindow post-Oilpan. The debug flag m_hasBeenReset no longer serves a purpose + OwnedPtrDeleter<> usage doesn't either. R= BUG=585328 Committed: https://crrev.com/dae4fae0687cdc97530392f676f3450ea0310e98 Cr-Commit-Position: refs/heads/master@{#390436}

Patch Set 1 #

Patch Set 2 : compile fix #

Patch Set 3 : continue using PersistentHeapHashCountedSet<> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -56 lines) Patch
M third_party/WebKit/Source/core/frame/LocalDOMWindow.h View 2 chunks +1 line, -26 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 2 4 chunks +38 lines, -30 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sof
please take a look. just some minor rough edges.
4 years, 7 months ago (2016-04-28 07:58:58 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-04-28 14:33:58 UTC) #3
dcheng
lgtm
4 years, 7 months ago (2016-04-28 17:21:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932653003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932653003/40001
4 years, 7 months ago (2016-04-28 17:36:50 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-28 18:56:58 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:19:58 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dae4fae0687cdc97530392f676f3450ea0310e98
Cr-Commit-Position: refs/heads/master@{#390436}

Powered by Google App Engine
This is Rietveld 408576698