content/renderer/push_messaging/push_messaging_dispatcher.cc - Issue 1932623003: DevTools: Introduce Page.getManifest remote debugging protocol method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/push_messaging/push_messaging_dispatcher.cc

Issue 1932623003: DevTools: Introduce Page.getManifest remote debugging protocol method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: browser test updated Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/push_messaging/push_messaging_dispatcher.h ('k') | third_party/WebKit/Source/devtools/protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/push_messaging/push_messaging_dispatcher.cc

diff --git a/content/renderer/push_messaging/push_messaging_dispatcher.cc b/content/renderer/push_messaging/push_messaging_dispatcher.cc

index 1cfc044fb31a24b704dbe8e5c64891b7d977663c..e25af93c6db07e62e8085e9e720296273e3399a5 100644

--- a/content/renderer/push_messaging/push_messaging_dispatcher.cc

+++ b/content/renderer/push_messaging/push_messaging_dispatcher.cc

@@ -67,7 +67,8 @@ void PushMessagingDispatcher::DidGetManifest(

blink::WebServiceWorkerRegistration* service_worker_registration,

const blink::WebPushSubscriptionOptions& options,

blink::WebPushSubscriptionCallbacks* callbacks,

- const Manifest& manifest) {

+ const Manifest& manifest,

+ const ManifestDebugInfo&) {

// Get the sender_info from the manifest since it wasn't provided by

// the caller.

if (manifest.IsEmpty()) {

« no previous file with comments | « content/renderer/push_messaging/push_messaging_dispatcher.h ('k') | third_party/WebKit/Source/devtools/protocol.json » ('j') | no next file with comments »