[Hera] Be smarter about dismissing the callout

[Hera] Be smarter about dismissing the callout

The runnable can run after the Activity has already died,
so be extra careful about getting rid of it.

* Let the ToolbarPhone know when the Activity is destroyed
  when the ToolbarManager gets destroyed.

* Keep track of the Handler and the Runnable that call
  #dismiss(), canceling it when necessary.

* Only let the Runnable dismiss the PopupWindow when it
  still thinks it is showing.

BUG=582539, 607391
Committed: https://crrev.com/13e602c1b2457501beb8bd52715200a782d91aee
Cr-Commit-Position: refs/heads/master@{#390303}

[gone, 2016-04-28 03:49:02]

dfalcantara@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ted C, 2016-04-28 04:00:11]

lgtm

https://codereview.chromium.org/1932623002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherCallout.java
(right):

https://codereview.chromium.org/1932623002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherCallout.java:84:
mDismissRunnable = new Runnable() {
I would define this here, but I would override show() and post the task there.

[gone, 2016-04-28 04:27:46]

https://codereview.chromium.org/1932623002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherCallout.java
(right):

https://codereview.chromium.org/1932623002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherCallout.java:84:
mDismissRunnable = new Runnable() {
On 2016/04/28 04:00:11, Ted C wrote:
> I would define this here, but I would override show() and post the task there.

Done.

[gone, 2016-04-28 04:27:50]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-04-28 04:27:50]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/1932623002/#ps20001
(title: "Override show()")

[commit-bot: I haz the power, 2016-04-28 04:28:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1932623002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1932623002/20001

[commit-bot: I haz the power, 2016-04-28 05:02:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-30 17:16:17]

Patchset 2 (id:??) landed as
https://crrev.com/13e602c1b2457501beb8bd52715200a782d91aee
Cr-Commit-Position: refs/heads/master@{#390303}

[commit-bot: I haz the power, 2016-04-30 17:54:15]

Description was changed from

==========
[Hera] Be smarter about dismissing the callout

The runnable can run after the Activity has already died,
so be extra careful about getting rid of it.

* Let the ToolbarPhone know when the Activity is destroyed
  when the ToolbarManager gets destroyed.

* Keep track of the Handler and the Runnable that call
  #dismiss(), canceling it when necessary.

* Only let the Runnable dismiss the PopupWindow when it
  still thinks it is showing.

BUG=582539,607391
==========

to

==========
[Hera] Be smarter about dismissing the callout

The runnable can run after the Activity has already died,
so be extra careful about getting rid of it.

* Let the ToolbarPhone know when the Activity is destroyed
  when the ToolbarManager gets destroyed.

* Keep track of the Handler and the Runnable that call
  #dismiss(), canceling it when necessary.

* Only let the Runnable dismiss the PopupWindow when it
  still thinks it is showing.

BUG=582539,607391

Committed: https://crrev.com/13e602c1b2457501beb8bd52715200a782d91aee
Cr-Commit-Position: refs/heads/master@{#390303}
==========