Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 1932583002: Use ErrorReporter in many places. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -130 lines) Patch
M pkg/analyzer/lib/src/generated/element_resolver.dart View 20 chunks +43 lines, -33 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 16 chunks +63 lines, -96 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 7 months ago (2016-04-28 01:20:43 UTC) #1
Brian Wilkerson
lgtm
4 years, 7 months ago (2016-04-28 13:50:42 UTC) #2
scheglov
4 years, 7 months ago (2016-04-28 20:59:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
68caf7074f344a0396c5381697afcbb60796fdb5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698