Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1932513002: Replace CFX_PtrArray with type-safe CFX_ArrayTemplate, Part 2 (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Replace CFX_PtrArray with type-safe CFX_ArrayTemplate, Part 2 Capitalize m_bindItems while we're at it. Committed: https://pdfium.googlesource.com/pdfium/+/0e5f87a278e8502dc5c64e6882f4d2bf6c298783

Patch Set 1 #

Total comments: 1

Patch Set 2 : No {}. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -32 lines) Patch
M xfa/fxfa/app/xfa_ffdocview.cpp View 1 11 chunks +19 lines, -25 lines 0 comments Download
M xfa/fxfa/app/xfa_ffnotify.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/include/xfa_ffdocview.h View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Tom Sepez
Lei, for review.
4 years, 7 months ago (2016-04-27 22:27:17 UTC) #3
Lei Zhang
lgtm https://codereview.chromium.org/1932513002/diff/1/xfa/fxfa/app/xfa_ffdocview.cpp File xfa/fxfa/app/xfa_ffdocview.cpp (right): https://codereview.chromium.org/1932513002/diff/1/xfa/fxfa/app/xfa_ffdocview.cpp#newcode745 xfa/fxfa/app/xfa_ffdocview.cpp:745: if (m_BindItems[i]->HasFlag(XFA_NODEFLAG_HasRemoved)) { no braces
4 years, 7 months ago (2016-04-27 22:32:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932513002/20001
4 years, 7 months ago (2016-04-27 22:38:00 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 22:51:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/0e5f87a278e8502dc5c64e6882f4d2bf6c29...

Powered by Google App Engine
This is Rietveld 408576698