Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1932503002: Fix mash shelf id mapping and removal. (Closed)

Created:
4 years, 7 months ago by msw
Modified:
4 years, 7 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix mash shelf id mapping and removal. Add ShelfID to app_id mapping, to complement the inverse map. (these are 1-to-1 mappings, but two maps eases usage) Remove mappings when shelf items are removed. Implement the ShelfDelegate interface mapping functions. TODO: Add unit/shell testing of ShelfDelegateMus. BUG=607271 TEST=|ShelfDelegaeMus::app_id_to_shelf_id_| shrinks as appropriate. R=sadrul@chromium.org,sky@chromium.org Committed: https://crrev.com/4875d4b179e246bdc4a903bc3d20c831727eecca Cr-Commit-Position: refs/heads/master@{#390289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M ash/mus/shelf_delegate_mus.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/mus/shelf_delegate_mus.cc View 5 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
msw
Hey Sadrul, please take a look; thanks!
4 years, 7 months ago (2016-04-27 21:42:21 UTC) #3
sadrul
lgtm. Thanks!
4 years, 7 months ago (2016-04-27 22:49:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932503002/1
4 years, 7 months ago (2016-04-27 23:18:56 UTC) #6
msw
+Scott for owners, please take a look; thanks!
4 years, 7 months ago (2016-04-27 23:20:04 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/174361)
4 years, 7 months ago (2016-04-27 23:29:26 UTC) #11
sky
LGTM
4 years, 7 months ago (2016-04-27 23:57:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932503002/1
4 years, 7 months ago (2016-04-28 03:25:31 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 03:32:53 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:15:55 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4875d4b179e246bdc4a903bc3d20c831727eecca
Cr-Commit-Position: refs/heads/master@{#390289}

Powered by Google App Engine
This is Rietveld 408576698