Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js

Issue 1932483002: DevTools: add measurement units to profile tree headers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js
index defd13197937ad2fbacd05127974e09b29306ded..fb438384fdb01af51ffc2360bdc6a28065c760fc 100644
--- a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js
+++ b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js
@@ -26,8 +26,8 @@ WebInspector.ProfileView = function(nodeFormatter, viewTypes)
this._nodeFormatter = nodeFormatter;
var columns = [];
- columns.push({id: "self", title: WebInspector.UIString("Self"), width: "120px", sort: WebInspector.DataGrid.Order.Descending, sortable: true});
- columns.push({id: "total", title: WebInspector.UIString("Total"), width: "120px", sortable: true});
+ columns.push({id: "self", title: WebInspector.UIString("Self %s", this.units()), width: "120px", sort: WebInspector.DataGrid.Order.Descending, sortable: true});
+ columns.push({id: "total", title: WebInspector.UIString("Total %s", this.units()), width: "120px", sortable: true});
columns.push({id: "function", title: WebInspector.UIString("Function"), disclosure: true, sortable: true});
this.dataGrid = new WebInspector.DataGrid(columns);
@@ -82,6 +82,14 @@ WebInspector.ProfileView.prototype = {
},
/**
+ * @return {string}
+ */
+ units: function()
+ {
+ return "";
caseq 2016/04/27 21:24:08 should we throw "not implemented" instead?
alph 2016/04/28 00:47:26 Done.
+ },
+
+ /**
* @return {?WebInspector.Target}
*/
target: function()

Powered by Google App Engine
This is Rietveld 408576698