Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js

Issue 1932483002: DevTools: add measurement units to profile tree headers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js b/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js
index a68088826593abc9bf751690b4d097ba65806437..9657d48668c1a4ead53d2e508db38c23965df6f0 100644
--- a/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js
+++ b/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js
@@ -39,6 +39,15 @@ WebInspector.CPUProfileView = function(profileHeader)
}
WebInspector.CPUProfileView.prototype = {
+ /**
+ * @override
+ * @return {string}
+ */
+ units: function()
+ {
+ return "Time [ms]";
caseq 2016/04/27 21:24:07 WebInspector.UIString(). Also, "(ms)" perhaps?
alph 2016/04/28 00:47:26 Done.
+ },
+
__proto__: WebInspector.ProfileView.prototype
}
@@ -294,7 +303,7 @@ WebInspector.CPUProfileView.NodeFormatter.prototype = {
*/
formatValue: function(value)
{
- return WebInspector.UIString("%.1f\u2009ms", value);
+ return WebInspector.UIString("%.1f", value);
caseq 2016/04/27 21:24:07 String.vsprintf() perhaps -- this is no longer UIS
alph 2016/04/28 00:47:26 Done.
},
/**

Powered by Google App Engine
This is Rietveld 408576698