DevTools: add measurement units to profile tree headers.

third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @implements {WebInspector.Searchable}
  * @extends {WebInspector.VBox}
  * @param {!WebInspector.ProfileDataGridNode.Formatter} nodeFormatter
  * @param {!Array<string>=} viewTypes
  */
 WebInspector.ProfileView = function(nodeFormatter, viewTypes)
 {
     WebInspector.VBox.call(this);
 
     this._searchableView = new WebInspector.SearchableView(this);
     this._searchableView.setPlaceholder(WebInspector.UIString("Find by cost (>50ms), name or file"));
     this._searchableView.show(this.element);
 
     viewTypes = viewTypes || [
         WebInspector.ProfileView.ViewTypes.Flame,
         WebInspector.ProfileView.ViewTypes.Heavy,
         WebInspector.ProfileView.ViewTypes.Tree
     ];
     this._viewType = WebInspector.settings.createSetting("profileView", WebInspector.ProfileView.ViewTypes.Heavy);
     this._nodeFormatter = nodeFormatter;
 
     var columns = [];
-    columns.push({id: "self", title: WebInspector.UIString("Self"), width: "120px", sort: WebInspector.DataGrid.Order.Descending, sortable: true});
-    columns.push({id: "total", title: WebInspector.UIString("Total"), width: "120px", sortable: true});
+    columns.push({id: "self", title: WebInspector.UIString("Self %s", this.units()), width: "120px", sort: WebInspector.DataGrid.Order.Descending, sortable: true});
+    columns.push({id: "total", title: WebInspector.UIString("Total %s", this.units()), width: "120px", sortable: true});
     columns.push({id: "function", title: WebInspector.UIString("Function"), disclosure: true, sortable: true});
 
     this.dataGrid = new WebInspector.DataGrid(columns);
     this.dataGrid.addEventListener(WebInspector.DataGrid.Events.SortingChanged, this._sortProfile, this);
     this.dataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._nodeSelected.bind(this, true));
     this.dataGrid.addEventListener(WebInspector.DataGrid.Events.DeselectedNode, this._nodeSelected.bind(this, false));
 
     this.viewSelectComboBox = new WebInspector.ToolbarComboBox(this._changeView.bind(this));
     var optionNames = new Map([
         [WebInspector.ProfileView.ViewTypes.Flame, WebInspector.UIString("Chart")],
@@ skipping 34 matching lines @@
 WebInspector.ProfileView.prototype = {
     focus: function()
     {
         if (this._flameChart)
             this._flameChart.focus();
         else
             WebInspector.Widget.prototype.focus.call(this);
     },
 
     /**
+     * @return {string}
+     */
+    units: function()
+    {
+        return "";

[caseq, 2016/04/27 21:24:08]

should we throw "not implemented" instead?

[alph, 2016/04/28 00:47:26]

Done.

+    },
+
+    /**
      * @return {?WebInspector.Target}
      */
     target: function()
     {
         return this._profileHeader.target();
     },
 
     /**
      * @param {number} timeLeft
      * @param {number} timeRight
@@ skipping 468 matching lines @@
     _notifyTempFileReady: function()
     {
         if (this._onTempFileReady) {
             this._onTempFileReady();
             this._onTempFileReady = null;
         }
     },
 
     __proto__: WebInspector.ProfileHeader.prototype
 }