Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1932483002: DevTools: add measurement units to profile tree headers. (Closed)

Created:
4 years, 7 months ago by alph
Modified:
4 years, 7 months ago
Reviewers:
caseq, paulirish
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add measurement units to profile tree headers. Committed: https://crrev.com/1044f94f1427341d15abd101c783a03c9cae7fe9 Cr-Commit-Position: refs/heads/master@{#390277}

Patch Set 1 #

Total comments: 8

Patch Set 2 : addressing comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js View 1 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js View 1 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js View 1 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
alph
4 years, 7 months ago (2016-04-27 20:59:06 UTC) #2
caseq
lgtm https://codereview.chromium.org/1932483002/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js File third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js (right): https://codereview.chromium.org/1932483002/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js#newcode48 third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js:48: return "Time [ms]"; WebInspector.UIString(). Also, "(ms)" perhaps? https://codereview.chromium.org/1932483002/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js#newcode306 ...
4 years, 7 months ago (2016-04-27 21:24:08 UTC) #3
alph
https://codereview.chromium.org/1932483002/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js File third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js (right): https://codereview.chromium.org/1932483002/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js#newcode48 third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js:48: return "Time [ms]"; On 2016/04/27 21:24:07, caseq wrote: > ...
4 years, 7 months ago (2016-04-28 00:47:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932483002/20001
4 years, 7 months ago (2016-04-28 00:47:51 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 02:25:09 UTC) #8
paulirish
lgtm
4 years, 7 months ago (2016-04-28 22:48:50 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:15:38 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1044f94f1427341d15abd101c783a03c9cae7fe9
Cr-Commit-Position: refs/heads/master@{#390277}

Powered by Google App Engine
This is Rietveld 408576698