Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: ash/shelf/shelf_button.h

Issue 1932433002: Update activity indicator from a light bar to a point (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/shelf/shelf_button.cc » ('j') | ash/shelf/shelf_button.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_button.h
diff --git a/ash/shelf/shelf_button.h b/ash/shelf/shelf_button.h
index 4a84a61a532d502bb5d7a60e0047ef4beea274a6..7a55f1183789cabf66a3f7fc52d13d9f1adc4118 100644
--- a/ash/shelf/shelf_button.h
+++ b/ash/shelf/shelf_button.h
@@ -90,6 +90,9 @@ class ASH_EXPORT ShelfButton : public views::CustomButton {
// Updates the status bar (bitmap, orientation, visibility).
void UpdateBar();
+ // Create an light bar image
bruthig 2016/04/27 18:56:00 nit: spelling 'a' instead of 'an' nit: Use full pu
varkha 2016/04/28 16:49:04 nit: s/Create/Creates (https://google.github.io/st
yiyix 2016/05/02 15:55:04 Done.
yiyix 2016/05/02 15:55:04 Done.
+ void GetActivityIndicatorImage(gfx::Canvas& canvas);
varkha 2016/04/28 16:49:04 Maybe GetIndicatorImage() since we are not plannin
yiyix 2016/05/02 15:55:04 Done.
+
// The shelf view hosting this button.
ShelfView* shelf_view_;
« no previous file with comments | « no previous file | ash/shelf/shelf_button.cc » ('j') | ash/shelf/shelf_button.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698