chrome/browser/resources/md_history/side_bar.html - Issue 1932413003: [MD History] Refactor history.html into a history-app element.

Side by Side Diff: chrome/browser/resources/md_history/side_bar.html

Issue 1932413003: [MD History] Refactor history.html into a history-app element. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/md_history/history.js ('K') | « chrome/browser/resources/md_history/history.js ('k') | chrome/browser/resources/md_history/side_bar.js » ('j') | chrome/test/data/webui/md_history/md_history_browsertest.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/html/polymer.html">	1 <link rel="import" href="chrome://resources/html/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout.html">	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout.html">

3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">

4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-listbox/paper-lis tbox.html">	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-listbox/paper-lis tbox.html">

5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-ripple/paper-ripp le.html">	5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-ripple/paper-ripp le.html">

6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html ">	6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html ">

7 <link rel="import" href="chrome://history/shared_style.html">	7 <link rel="import" href="chrome://history/shared_style.html">

8	8

9 <dom-module id="history-side-bar">	9 <dom-module id="history-side-bar">

10 <template>	10 <template>

(...skipping 15 matching lines...) Expand all Loading...
26 font-weight: 500;	26 font-weight: 500;

27 }	27 }

28	28

29 paper-listbox {	29 paper-listbox {

30 -webkit-user-select: none;	30 -webkit-user-select: none;

31 background-color: transparent;	31 background-color: transparent;

32 color: #5a5a5a;	32 color: #5a5a5a;

33 }	33 }

34 </style>	34 </style>

35 <paper-listbox id="overflow-menu" selected="0" on-iron-select="onSelect_">	35 <paper-listbox id="overflow-menu" selected="0" on-iron-select="onSelect_">

36 <paper-item id="history-button">	36 <paper-item id="history-button" view-id="history-list">

37 <div>$i18n{historyMenuItem}</div>	37 <div>$i18n{historyMenuItem}</div>

38 <paper-ripple></paper-ripple>	38 <paper-ripple></paper-ripple>

39 </paper-item>	39 </paper-item>

40 <paper-item id="synced-tabs-button">	40 <paper-item id="synced-tabs-button" view-id="history-synced-device-manager ">
	tsergeant 2016/05/03 00:05:10 Looks like this line is over 80 characters. Can y Looks like this line is over 80 characters. Can you get rid of the IDs from here? I don't think they're necessary and that would save some space. calamity 2016/05/03 23:07:18 Done. Show quoted text On 2016/05/03 00:05:10, tsergeant (MTV) wrote: > Looks like this line is over 80 characters. > > Can you get rid of the IDs from here? I don't think they're necessary and that > would save some space. Done.
41 <div>$i18n{openTabsMenuItem}</div>	41 <div>$i18n{openTabsMenuItem}</div>

42 <paper-ripple></paper-ripple>	42 <paper-ripple></paper-ripple>

43 </paper-item>	43 </paper-item>

44 </paper-listbox>	44 </paper-listbox>

45 </template>	45 </template>

46 <script src="chrome://history/side_bar.js"></script>	46 <script src="chrome://history/side_bar.js"></script>

47 </dom-module>	47 </dom-module>

OLD	NEW