chrome/chrome_browser_ui.gypi - Issue 1932413002: Desktop Capture Picker New UI: Non Mac Structure Change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 1932413002: Desktop Capture Picker New UI: Non Mac Structure Change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/desktop_media_picker_views_deprecated_unittest.cc ('K') | « chrome/browser/ui/views/desktop_media_picker_views_unittest.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser_ui.gypi

diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi

index 4bb431c1c44bdb02a877c2ebf3ffaeee0f17c2c2..ced340747252b81aab7a2ea54917f32668afbdd5 100644

--- a/chrome/chrome_browser_ui.gypi

+++ b/chrome/chrome_browser_ui.gypi

@@ -681,8 +681,10 @@

'browser/ui/ime/ime_window.h',

'browser/ui/views/crypto_module_password_dialog_view.cc',

'browser/ui/views/crypto_module_password_dialog_view.h',

- 'browser/ui/views/desktop_media_picker_views.cc',

- 'browser/ui/views/desktop_media_picker_views.h',

+ 'browser/ui/views/desktop_capture/desktop_media_picker_views.cc',

msw 2016/05/05 23:56:10 nit/q: why create a desktop_capture subdir? Seems

qiangchen 2016/05/06 18:38:36 In next CL, we are going to apply different appear

+ 'browser/ui/views/desktop_capture/desktop_media_picker_views.h',

+ 'browser/ui/views/desktop_media_picker_views_deprecated.cc',

+ 'browser/ui/views/desktop_media_picker_views_deprecated.h',

'browser/ui/views/ime/ime_window_frame_view.cc',

'browser/ui/views/ime/ime_window_frame_view.h',

'browser/ui/views/ime/ime_window_view.cc',