Desktop Capture Picker New UI: Non Mac Structure Change

chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_UI_VIEWS_DESKTOP_MEDIA_PICKER_VIEWS_H_
-#define CHROME_BROWSER_UI_VIEWS_DESKTOP_MEDIA_PICKER_VIEWS_H_
+#ifndef CHROME_BROWSER_UI_VIEWS_DESKTOP_CAPTURE_DESKTOP_MEDIA_PICKER_VIEWS_H_
+#define CHROME_BROWSER_UI_VIEWS_DESKTOP_CAPTURE_DESKTOP_MEDIA_PICKER_VIEWS_H_
 
 #include "base/macros.h"
 #include "chrome/browser/media/desktop_media_list_observer.h"
 #include "chrome/browser/media/desktop_media_picker.h"
+#include "ui/views/controls/tabbed_pane/tabbed_pane_listener.h"
 #include "ui/views/window/dialog_delegate.h"
 
 namespace views {
 class ImageView;
 class Label;
+class LabelButton;

[msw, 2016/05/02 23:49:58]

Remove this.

[qiangchen, 2016/05/05 22:17:54]

Done.

 class Checkbox;
+class TabbedPane;
 }  // namespace views
 
 class DesktopMediaPickerDialogView;
 class DesktopMediaPickerViews;
 class DesktopMediaSourceView;
 
 // View that shows a list of desktop media sources available from
 // DesktopMediaList.
 class DesktopMediaListView : public views::View,
                              public DesktopMediaListObserver {
@@ skipping 78 matching lines @@
 
   views::ImageView* image_view_;
   views::Label* label_;
 
   bool selected_;
 
   DISALLOW_COPY_AND_ASSIGN(DesktopMediaSourceView);
 };
 
 // Dialog view used for DesktopMediaPickerViews.
-class DesktopMediaPickerDialogView : public views::DialogDelegateView {
+class DesktopMediaPickerDialogView : public views::DialogDelegateView,
+                                     public views::TabbedPaneListener {
  public:
   DesktopMediaPickerDialogView(content::WebContents* parent_web_contents,
                                gfx::NativeWindow context,
                                DesktopMediaPickerViews* parent,
                                const base::string16& app_name,
                                const base::string16& target_name,
                                std::unique_ptr<DesktopMediaList> screen_list,
                                std::unique_ptr<DesktopMediaList> window_list,
                                std::unique_ptr<DesktopMediaList> tab_list,
                                bool request_audio);
   ~DesktopMediaPickerDialogView() override;
 
   // Called by parent (DesktopMediaPickerViews) when it's destroyed.
   void DetachParent();
 
   // Called by DesktopMediaListView.
   void OnSelectionChanged();
   void OnDoubleClick();
 
+  // Called by clicking pane tab buttons.

[msw, 2016/05/02 23:49:58]

Typically subclass function overrides are simply annotated with the name of the
subclass, like below "// views::View overrides.", change this to "//
views::TabbedPaneListener overrides."

[qiangchen, 2016/05/05 22:17:54]

Done.

+  void TabSelectedAt(int index) override;
+
   // views::View overrides.
   gfx::Size GetPreferredSize() const override;
+  void Layout() override;
 
   // views::DialogDelegateView overrides.
   ui::ModalType GetModalType() const override;
   base::string16 GetWindowTitle() const override;
   bool IsDialogButtonEnabled(ui::DialogButton button) const override;
   views::View* GetInitiallyFocusedView() override;
   base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;
+  bool ShouldDefaultButtonBeBlue() const override;

[msw, 2016/05/02 23:49:58]

Order just before GetDialogButtonLabel(), to match the subclass decl order.

[qiangchen, 2016/05/05 22:17:54]

Done.

   bool Accept() override;
   void DeleteDelegate() override;
 
   void OnMediaListRowsChanged();
 
   DesktopMediaListView* GetMediaListViewForTesting() const;
   DesktopMediaSourceView* GetMediaSourceViewForTesting(int index) const;
+  views::Checkbox* GetCheckboxForTesting() const;
+  int GetIndexOfSourceTypeForTesting(
+      content::DesktopMediaID::Type source_type) const;
+  views::TabbedPane* GetPaneForTesting() const;
 
  private:
+  void SwitchSourceType(int index);

[msw, 2016/05/02 23:49:58]

nit: add a blank line after

[qiangchen, 2016/05/05 22:17:54]

Done.

   DesktopMediaPickerViews* parent_;
   base::string16 app_name_;
 
   views::Label* description_label_;
 
-  // |audio_share_checked_| records whether the user permits audio, when
-  // |audio_share_checkbox_| is disabled.
   views::Checkbox* audio_share_checkbox_;
-  bool audio_share_checked_;
 
-  views::ScrollView* sources_scroll_view_;
-  DesktopMediaListView* sources_list_view_;
+  views::TabbedPane* pane_;
+  std::vector<views::ScrollView*> scroll_views_;
+  std::vector<DesktopMediaListView*> list_views_;
+  std::vector<content::DesktopMediaID::Type> source_types_;
 
   DISALLOW_COPY_AND_ASSIGN(DesktopMediaPickerDialogView);
 };
 
 // Implementation of DesktopMediaPicker for Views.
 class DesktopMediaPickerViews : public DesktopMediaPicker {
  public:
   DesktopMediaPickerViews();
   ~DesktopMediaPickerViews() override;
 
@@ skipping 19 matching lines @@
   DoneCallback callback_;
 
   // The |dialog_| is owned by the corresponding views::Widget instance.
   // When DesktopMediaPickerViews is destroyed the |dialog_| is destroyed
   // asynchronously by closing the widget.
   DesktopMediaPickerDialogView* dialog_;
 
   DISALLOW_COPY_AND_ASSIGN(DesktopMediaPickerViews);
 };
 
-#endif  // CHROME_BROWSER_UI_VIEWS_DESKTOP_MEDIA_PICKER_VIEWS_H_
+#endif  // CHROME_BROWSER_UI_VIEWS_DESKTOP_CAPTURE_DESKTOP_MEDIA_PICKER_VIEWS_H_