components/signin/core/browser/signin_investigator.cc - Issue 1932343003: [Sync] Removed a DCHECK in SigninInvestigator for a valid scenario.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/signin_investigator.cc

Issue 1932343003: [Sync] Removed a DCHECK in SigninInvestigator for a valid scenario. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/signin/core/browser/signin_investigator.cc

diff --git a/components/signin/core/browser/signin_investigator.cc b/components/signin/core/browser/signin_investigator.cc

index 994a936c1f8c10d20059df89bf4ab9f21e95d3fd..83961de5aaf6e5d2032d159bd9c53a28600868bc 100644

--- a/components/signin/core/browser/signin_investigator.cc

+++ b/components/signin/core/browser/signin_investigator.cc

@@ -28,7 +28,7 @@ SigninInvestigator::SigninInvestigator(const std::string& current_email,

current_id_(current_id),

provider_(provider) {

DCHECK(!current_email_.empty());

- DCHECK(!current_id_.empty());

+ DCHECK(provider);

}

SigninInvestigator::~SigninInvestigator() {}

« no previous file with comments | « no previous file | components/signin/core/browser/signin_investigator_unittest.cc » ('j') | no next file with comments »