[DevTools] Don't run microtasks after call to InjectedScript

[DevTools] Don't run microtasks after call to InjectedScript

- all calls to injected script doesn't produce microtask checkpoint,
- Runtime.evaluate produces microtask checkpoint.

R=dgozman@chromium.org
BUG=595206, 608138
Committed: https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39
Cr-Commit-Position: refs/heads/master@{#390863}

[kozy, 2016-04-29 19:20:12]

Description was changed from

==========
[DevTools] Don't run microtasks after call to InjectedScript

- all calls to injected script doesn't produce microtask checkpoint,
- Runtime.evaluate call produce microtask checkpoint.

R=dgozman@chromium.org
==========

to

==========
[DevTools] Don't run microtasks after call to InjectedScript

- all calls to injected script doesn't produce microtask checkpoint,
- Runtime.evaluate call produce microtask checkpoint.

R=dgozman@chromium.org
BUG=595206
==========

[kozy, 2016-04-29 19:20:37]

Description was changed from

==========
[DevTools] Don't run microtasks after call to InjectedScript

- all calls to injected script doesn't produce microtask checkpoint,
- Runtime.evaluate call produce microtask checkpoint.

R=dgozman@chromium.org
BUG=595206
==========

to

==========
[DevTools] Don't run microtasks after call to InjectedScript

- all calls to injected script doesn't produce microtask checkpoint,
- Runtime.evaluate produces microtask checkpoint.

R=dgozman@chromium.org
BUG=595206
==========

[kozy, 2016-04-29 19:21:05]

Dmitry, please take a look.

[dgozman, 2016-04-30 00:07:01]

Does this also fix the "step into goes to injected script code" problem due to
willExecuteScript/didExecuteScript calls? Let's add a test for this as well!

https://codereview.chromium.org/1932343002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-doesnt-run-microtasks.html
(right):

https://codereview.chromium.org/1932343002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-doesnt-run-microtasks.html:19:
var messageCount = 3;
If something goes wrong, this test will timeout. Can we instead
console.log("FOO") afterwards and completeTest when message contains FOO?

https://codereview.chromium.org/1932343002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/1932343002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:165:
v8::MaybeLocal<v8::Value> maybeFunctionValue =
m_debugger->compileAndRunInternalScript(scope.context(),
toV8String(m_debugger->isolate(), "(" + expression + ")"));
Change this place as well and add a test.

[dgozman, 2016-04-30 00:08:33]

https://codereview.chromium.org/1932343002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/1932343002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:165:
v8::MaybeLocal<v8::Value> maybeFunctionValue =
m_debugger->compileAndRunInternalScript(scope.context(),
toV8String(m_debugger->isolate(), "(" + expression + ")"));
On 2016/04/30 00:07:01, dgozman wrote:
> Change this place as well and add a test.

Nevermind. I did misread this.

[dgozman, 2016-04-30 00:19:51]

Let's try to do the test in render_view_browsertest.cc to avoid others
triggering promises.

[kozy, 2016-04-30 02:10:17]

Added tests.

Dmitry, please take a look.

[dgozman, 2016-04-30 02:26:07]

Nice tests! Thanks!

lgtm

https://codereview.chromium.org/1932343002/diff/40001/content/renderer/render...
File content/renderer/render_view_browsertest.cc (right):

https://codereview.chromium.org/1932343002/diff/40001/content/renderer/render...
content/renderer/render_view_browsertest.cc:2445: EXPECT_TRUE(static_cast<const
base::DictionaryValue*>(root.get())
No need to cast.

https://codereview.chromium.org/1932343002/diff/40001/content/renderer/render...
content/renderer/render_view_browsertest.cc:2451: EXPECT_TRUE(static_cast<const
base::DictionaryValue*>(object)->Get(
std::string object_id;
root->GetStringASCII("result.result.objectId", &object_id);

https://codereview.chromium.org/1932343002/diff/40001/content/renderer/render...
content/renderer/render_view_browsertest.cc:2469: EXPECT_EQ(1,
CountNotifications("Console.messageAdded"));
Could we also add test for "Runtime.getProperties" not triggering the promise?

[kozy, 2016-04-30 02:31:25]

kozyatinskiy@chromium.org changed reviewers:
+ pfeldman@chromium.org

[kozy, 2016-04-30 02:31:26]

Pavel, I need owner lgtm, ptal!

[pfeldman, 2016-04-30 02:32:28]

lgtm

[kozy, 2016-04-30 03:08:30]

All done except one more test.
I'll add a test in follow up.

https://codereview.chromium.org/1932343002/diff/40001/content/renderer/render...
File content/renderer/render_view_browsertest.cc (right):

https://codereview.chromium.org/1932343002/diff/40001/content/renderer/render...
content/renderer/render_view_browsertest.cc:2445: EXPECT_TRUE(static_cast<const
base::DictionaryValue*>(root.get())
On 2016/04/30 02:26:07, dgozman wrote:
> No need to cast.

Done.

https://codereview.chromium.org/1932343002/diff/40001/content/renderer/render...
content/renderer/render_view_browsertest.cc:2451: EXPECT_TRUE(static_cast<const
base::DictionaryValue*>(object)->Get(
On 2016/04/30 02:26:06, dgozman wrote:
> std::string object_id;
> root->GetStringASCII("result.result.objectId", &object_id);

Done.

https://codereview.chromium.org/1932343002/diff/40001/content/renderer/render...
content/renderer/render_view_browsertest.cc:2469: EXPECT_EQ(1,
CountNotifications("Console.messageAdded"));
On 2016/04/30 02:26:07, dgozman wrote:
> Could we also add test for "Runtime.getProperties" not triggering the promise?

I'll add a test for this in follow up.

[kozy, 2016-04-30 03:11:11]

Description was changed from

==========
[DevTools] Don't run microtasks after call to InjectedScript

- all calls to injected script doesn't produce microtask checkpoint,
- Runtime.evaluate produces microtask checkpoint.

R=dgozman@chromium.org
BUG=595206
==========

to

==========
[DevTools] Don't run microtasks after call to InjectedScript

- all calls to injected script doesn't produce microtask checkpoint,
- Runtime.evaluate produces microtask checkpoint.

R=dgozman@chromium.org
BUG=595206,608138
==========

[kozy, 2016-04-30 03:11:18]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-04-30 03:11:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1932343002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-04-30 03:11:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1932343002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1932343002/60001

[commit-bot: I haz the power, 2016-04-30 03:58:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-30 03:58:26]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kozy, 2016-04-30 04:51:06]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-04-30 04:51:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1932343002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-04-30 04:51:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1932343002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1932343002/80001

[commit-bot: I haz the power, 2016-04-30 06:02:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-30 06:02:51]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kozy, 2016-04-30 16:13:18]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-04-30 16:13:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1932343002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-04-30 16:13:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1932343002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1932343002/100001

[commit-bot: I haz the power, 2016-04-30 16:53:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-30 16:53:16]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kozy, 2016-04-30 19:53:02]

Patchset #6 (id:100001) has been deleted

[kozy, 2016-04-30 19:53:12]

Patchset #5 (id:80001) has been deleted

[kozy, 2016-04-30 19:53:28]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-04-30 19:53:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1932343002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-04-30 19:53:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1932343002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1932343002/120001

[commit-bot: I haz the power, 2016-04-30 21:44:10]

Description was changed from

==========
[DevTools] Don't run microtasks after call to InjectedScript

- all calls to injected script doesn't produce microtask checkpoint,
- Runtime.evaluate produces microtask checkpoint.

R=dgozman@chromium.org
BUG=595206,608138
==========

to

==========
[DevTools] Don't run microtasks after call to InjectedScript

- all calls to injected script doesn't produce microtask checkpoint,
- Runtime.evaluate produces microtask checkpoint.

R=dgozman@chromium.org
BUG=595206,608138
==========

[commit-bot: I haz the power, 2016-04-30 21:44:11]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-04-30 21:45:53]

Description was changed from

==========
[DevTools] Don't run microtasks after call to InjectedScript

- all calls to injected script doesn't produce microtask checkpoint,
- Runtime.evaluate produces microtask checkpoint.

R=dgozman@chromium.org
BUG=595206,608138
==========

to

==========
[DevTools] Don't run microtasks after call to InjectedScript

- all calls to injected script doesn't produce microtask checkpoint,
- Runtime.evaluate produces microtask checkpoint.

R=dgozman@chromium.org
BUG=595206,608138

Committed: https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39
Cr-Commit-Position: refs/heads/master@{#390863}
==========

[commit-bot: I haz the power, 2016-04-30 21:45:55]

Patchset 5 (id:??) landed as
https://crrev.com/a03cc9b51b4a88cffab3ffcfb4fc591606463d39
Cr-Commit-Position: refs/heads/master@{#390863}