Issue 1932333002: Revert of Switch ClangToTLinuxASan from gyp to gn.

Issue 1932333002: Revert of Switch ClangToTLinuxASan from gyp to gn. (Closed)

Created:
4 years, 7 months ago by Nico

Modified:
4 years, 7 months ago

Reviewers:
hans, Dirk Pranke

CC:
chromium-reviews, Dirk Pranke

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Switch ClangToTLinuxASan from gyp to gn. (patchset #1 id:1 of https://codereview.chromium.org/1924173004/ ) Reason for revert: ASan builds don't work in gn yet (for nacl targets): https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/4000/steps/compile/logs/stdio [822/41484] LINK ./libc_free_x86_64.nexe FAILED: libc_free_x86_64.nexe ../../third_party/llvm-build/Release+Asserts/bin/clang++ -nostdlib -shared -Wl,--no-undefined -Qunused-arguments -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold -pthread -m64 -Wl,-O1 -Wl,--gc-sections --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -fsanitize=address -fsanitize=leak -Wl,-rpath-link=../Release -Wl,--disable-new-dtags -Wl,-rpath=\$ORIGIN/. -Wl,-rpath-link=. -o "./libc_free_x86_64.nexe" -Wl,--start-group @"./libc_free_x86_64.nexe.rsp" -Wl,--end-group -ldl -lrt ../../chrome/test/data/nacl/nonsfi/libc_free.c:214: error: undefined reference to '__asan_option_detect_stack_use_after_return' ../../chrome/test/data/nacl/nonsfi/libc_free.c:214: error: undefined reference to '__asan_stack_malloc_1' Original issue's description: > Switch ClangToTLinuxASan from gyp to gn. > > The other two ClangToTLinux bots are blocked on other things happening > first (ubsan tests aren't green in gn builds yet, crbug.com/606003, > and gn doesn't have linux_dump_symbols yet, crbug.com/605819) > > BUG=605732 TBR=hans@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=605732 Committed: https://crrev.com/341939b904f5d6079e3c13f7678a242359275263 Cr-Commit-Position: refs/heads/master@{#390708}

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tools/mb/mb_config.pyl	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932333002/1

4 years, 7 months ago (2016-04-29 18:39:01 UTC) #2

commit-bot: I haz the power

Description was changed from ========== Revert of Switch ClangToTLinuxASan from gyp to gn. (patchset #1 ...

4 years, 7 months ago (2016-04-29 18:45:06 UTC) #3

Message was sent while issue was closed.

Description was changed from

==========
Revert of Switch ClangToTLinuxASan from gyp to gn. (patchset #1 id:1 of
https://codereview.chromium.org/1924173004/ )

Reason for revert:
ASan builds don't work in gn yet (for nacl targets):
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/4...

[822/41484] LINK ./libc_free_x86_64.nexe
FAILED: libc_free_x86_64.nexe 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -nostdlib -shared
-Wl,--no-undefined -Qunused-arguments -Wl,--fatal-warnings -fPIC
-Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro
-B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold -pthread -m64
-Wl,-O1 -Wl,--gc-sections
--sysroot=../../build/linux/debian_wheezy_amd64-sysroot  -fsanitize=address
-fsanitize=leak -Wl,-rpath-link=../Release -Wl,--disable-new-dtags
-Wl,-rpath=\$ORIGIN/. -Wl,-rpath-link=. -o "./libc_free_x86_64.nexe"
-Wl,--start-group @"./libc_free_x86_64.nexe.rsp"  -Wl,--end-group  -ldl -lrt 
../../chrome/test/data/nacl/nonsfi/libc_free.c:214: error: undefined reference
to '__asan_option_detect_stack_use_after_return'
../../chrome/test/data/nacl/nonsfi/libc_free.c:214: error: undefined reference
to '__asan_stack_malloc_1'


Original issue's description:
> Switch ClangToTLinuxASan from gyp to gn.
> 
> The other two ClangToTLinux bots are blocked on other things happening
> first (ubsan tests aren't green in gn builds yet, crbug.com/606003,
> and gn doesn't have linux_dump_symbols yet, crbug.com/605819)
> 
> BUG=605732

TBR=hans@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605732
==========

to

==========
Revert of Switch ClangToTLinuxASan from gyp to gn. (patchset #1 id:1 of
https://codereview.chromium.org/1924173004/ )

Reason for revert:
ASan builds don't work in gn yet (for nacl targets):
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/4...

[822/41484] LINK ./libc_free_x86_64.nexe
FAILED: libc_free_x86_64.nexe 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -nostdlib -shared
-Wl,--no-undefined -Qunused-arguments -Wl,--fatal-warnings -fPIC
-Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro
-B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold -pthread -m64
-Wl,-O1 -Wl,--gc-sections
--sysroot=../../build/linux/debian_wheezy_amd64-sysroot  -fsanitize=address
-fsanitize=leak -Wl,-rpath-link=../Release -Wl,--disable-new-dtags
-Wl,-rpath=\$ORIGIN/. -Wl,-rpath-link=. -o "./libc_free_x86_64.nexe"
-Wl,--start-group @"./libc_free_x86_64.nexe.rsp"  -Wl,--end-group  -ldl -lrt 
../../chrome/test/data/nacl/nonsfi/libc_free.c:214: error: undefined reference
to '__asan_option_detect_stack_use_after_return'
../../chrome/test/data/nacl/nonsfi/libc_free.c:214: error: undefined reference
to '__asan_stack_malloc_1'


Original issue's description:
> Switch ClangToTLinuxASan from gyp to gn.
> 
> The other two ClangToTLinux bots are blocked on other things happening
> first (ubsan tests aren't green in gn builds yet, crbug.com/606003,
> and gn doesn't have linux_dump_symbols yet, crbug.com/605819)
> 
> BUG=605732

TBR=hans@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605732
==========

commit-bot: I haz the power

4 years, 7 months ago (2016-04-30 17:27:38 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/341939b904f5d6079e3c13f7678a242359275263
Cr-Commit-Position: refs/heads/master@{#390708}

commit-bot: I haz the power

4 years, 7 months ago (2016-04-30 18:01:37 UTC) #7

Message was sent while issue was closed.

Description was changed from

==========
Revert of Switch ClangToTLinuxASan from gyp to gn. (patchset #1 id:1 of
https://codereview.chromium.org/1924173004/ )

Reason for revert:
ASan builds don't work in gn yet (for nacl targets):
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/4...

[822/41484] LINK ./libc_free_x86_64.nexe
FAILED: libc_free_x86_64.nexe 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -nostdlib -shared
-Wl,--no-undefined -Qunused-arguments -Wl,--fatal-warnings -fPIC
-Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro
-B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold -pthread -m64
-Wl,-O1 -Wl,--gc-sections
--sysroot=../../build/linux/debian_wheezy_amd64-sysroot  -fsanitize=address
-fsanitize=leak -Wl,-rpath-link=../Release -Wl,--disable-new-dtags
-Wl,-rpath=\$ORIGIN/. -Wl,-rpath-link=. -o "./libc_free_x86_64.nexe"
-Wl,--start-group @"./libc_free_x86_64.nexe.rsp"  -Wl,--end-group  -ldl -lrt 
../../chrome/test/data/nacl/nonsfi/libc_free.c:214: error: undefined reference
to '__asan_option_detect_stack_use_after_return'
../../chrome/test/data/nacl/nonsfi/libc_free.c:214: error: undefined reference
to '__asan_stack_malloc_1'


Original issue's description:
> Switch ClangToTLinuxASan from gyp to gn.
> 
> The other two ClangToTLinux bots are blocked on other things happening
> first (ubsan tests aren't green in gn builds yet, crbug.com/606003,
> and gn doesn't have linux_dump_symbols yet, crbug.com/605819)
> 
> BUG=605732

TBR=hans@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605732
==========

to

==========
Revert of Switch ClangToTLinuxASan from gyp to gn. (patchset #1 id:1 of
https://codereview.chromium.org/1924173004/ )

Reason for revert:
ASan builds don't work in gn yet (for nacl targets):
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/4...

[822/41484] LINK ./libc_free_x86_64.nexe
FAILED: libc_free_x86_64.nexe
../../third_party/llvm-build/Release+Asserts/bin/clang++ -nostdlib -shared
-Wl,--no-undefined -Qunused-arguments -Wl,--fatal-warnings -fPIC
-Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro
-B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold -pthread -m64
-Wl,-O1 -Wl,--gc-sections
--sysroot=../../build/linux/debian_wheezy_amd64-sysroot  -fsanitize=address
-fsanitize=leak -Wl,-rpath-link=../Release -Wl,--disable-new-dtags
-Wl,-rpath=\$ORIGIN/. -Wl,-rpath-link=. -o "./libc_free_x86_64.nexe"
-Wl,--start-group @"./libc_free_x86_64.nexe.rsp"  -Wl,--end-group  -ldl -lrt
../../chrome/test/data/nacl/nonsfi/libc_free.c:214: error: undefined reference
to '__asan_option_detect_stack_use_after_return'
../../chrome/test/data/nacl/nonsfi/libc_free.c:214: error: undefined reference
to '__asan_stack_malloc_1'

Original issue's description:
> Switch ClangToTLinuxASan from gyp to gn.
>
> The other two ClangToTLinux bots are blocked on other things happening
> first (ubsan tests aren't green in gn builds yet, crbug.com/606003,
> and gn doesn't have linux_dump_symbols yet, crbug.com/605819)
>
> BUG=605732

TBR=hans@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605732

Committed: https://crrev.com/341939b904f5d6079e3c13f7678a242359275263
Cr-Commit-Position: refs/heads/master@{#390708}
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages