Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 1932293002: Deprecate KeyboardEvent.keyIdentifier (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/events/KeyboardEvent.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/Deprecation.cpp
diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp
index 2d0af914da0bfa524b8382c82ca03db8bb3a67d8..764fec90e4503cb409c1c7fa51e28dd4af497f7d 100644
--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp
+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp
@@ -367,6 +367,9 @@ String Deprecation::deprecationMessage(UseCounter::Feature feature)
case UseCounter::WindowPostMessageWithLegacyTargetOriginArgument:
return replacedWillBeRemoved("'window.postMessage(message, transferables, targetOrigin)'", "'window.postMessage(message, targetOrigin, transferables)'", 54, "5719033043222528");
+ case UseCounter::V8KeyboardEvent_KeyIdentifier_AttributeGetter:
+ return willBeRemoved("'KeyboardEvent.keyIdentifier'", 53, "5316065118650368");
bokan 2016/04/29 17:38:54 I'm assuming the last argument should be the URL t
dtapuska 2016/04/29 17:41:13 see the sprintf here: https://code.google.com/p/c
+
// Features that aren't deprecated don't have a deprecation message.
default:
return String();
« no previous file with comments | « third_party/WebKit/Source/core/events/KeyboardEvent.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698