Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1932273002: Remove expectation for http/tests/fileapi/blob-url-in-subframe.html. (Closed)

Created:
4 years, 7 months ago by Łukasz Anforowicz
Modified:
4 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, blink-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove exceptions for tests fixed by teaching GetSiteForURL() about blob URLs. These tests got recently fixed by https://crrev.com/1911573002 BUG=602818 Committed: https://crrev.com/c95b1fe8a47162538c389ec2361332473437beda Cr-Commit-Position: refs/heads/master@{#390732}

Patch Set 1 #

Total comments: 2

Patch Set 2 : One more test got fixed - removing that expectation as well. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Łukasz Anforowicz
Nick, can you take a look please?
4 years, 7 months ago (2016-04-29 17:08:57 UTC) #2
ncarter (slow)
lgtm https://codereview.chromium.org/1932273002/diff/1/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process File third_party/WebKit/LayoutTests/FlagExpectations/site-per-process (right): https://codereview.chromium.org/1932273002/diff/1/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process#newcode12 third_party/WebKit/LayoutTests/FlagExpectations/site-per-process:12: http/tests/security/opened-document-security-origin-resets-on-navigation.html [ Crash ] I believe that CL ...
4 years, 7 months ago (2016-04-29 18:53:39 UTC) #3
Łukasz Anforowicz
Thanks for reviewing. https://codereview.chromium.org/1932273002/diff/1/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process File third_party/WebKit/LayoutTests/FlagExpectations/site-per-process (right): https://codereview.chromium.org/1932273002/diff/1/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process#newcode12 third_party/WebKit/LayoutTests/FlagExpectations/site-per-process:12: http/tests/security/opened-document-security-origin-resets-on-navigation.html [ Crash ] On 2016/04/29 ...
4 years, 7 months ago (2016-04-29 19:05:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932273002/20001
4 years, 7 months ago (2016-04-29 19:06:39 UTC) #8
ncarter (slow)
lgtm
4 years, 7 months ago (2016-04-29 19:06:39 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-29 20:14:18 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:28:12 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c95b1fe8a47162538c389ec2361332473437beda
Cr-Commit-Position: refs/heads/master@{#390732}

Powered by Google App Engine
This is Rietveld 408576698