Remove SkWriter32::contiguousArray().

Remove SkWriter32::contiguousArray().

This method requires SkWriter32 have a contiguous array.
It does, and I plan to keep it that way (last time we checked
it's faster), but this turns that feature back into an 
implementation detail.

This feature is only used by another unused feature, deep copies of
ops arrays in SkPictureData.  Kill that, kill this.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1932223003

Depends on https://codereview.chromium.org/1936563002/

Only deleting API
TBR=reed@google.com

Committed: https://skia.googlesource.com/skia/+/4d9ff62fa21326003cf5394cd1d16f4b4633102a

[mtklein_C, 2016-04-29 16:21:09]

Description was changed from

==========
Remove SkWriter32::contiguousArray().

This feature is only used by another unused feature, deep copies of
ops arrays in SkPictureData.  Kill that, kill this.

BUG=skia:
==========

to

==========
Remove SkWriter32::contiguousArray().

This feature is only used by another unused feature, deep copies of
ops arrays in SkPictureData.  Kill that, kill this.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein, 2016-04-29 18:01:25]

Description was changed from

==========
Remove SkWriter32::contiguousArray().

This feature is only used by another unused feature, deep copies of
ops arrays in SkPictureData.  Kill that, kill this.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove SkWriter32::contiguousArray().

This feature is only used by another unused feature, deep copies of
ops arrays in SkPictureData.  Kill that, kill this.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

COMMIT=false
Depends on https://codereview.chromium.org/1936563002/
==========

[mtklein, 2016-04-29 18:02:34]

Description was changed from

==========
Remove SkWriter32::contiguousArray().

This feature is only used by another unused feature, deep copies of
ops arrays in SkPictureData.  Kill that, kill this.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

COMMIT=false
Depends on https://codereview.chromium.org/1936563002/
==========

to

==========
Remove SkWriter32::contiguousArray().

This method requires SkWriter32 have a contiguous array.
It does, and I plan to keep it that way (last time we checked
it's faster), but this turns that feature back into an 
implementation detail.

This feature is only used by another unused feature, deep copies of
ops arrays in SkPictureData.  Kill that, kill this.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

COMMIT=false
Depends on https://codereview.chromium.org/1936563002/
==========

[mtklein, 2016-04-29 18:03:05]

Description was changed from

==========
Remove SkWriter32::contiguousArray().

This method requires SkWriter32 have a contiguous array.
It does, and I plan to keep it that way (last time we checked
it's faster), but this turns that feature back into an 
implementation detail.

This feature is only used by another unused feature, deep copies of
ops arrays in SkPictureData.  Kill that, kill this.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

COMMIT=false
Depends on https://codereview.chromium.org/1936563002/
==========

to

==========
Remove SkWriter32::contiguousArray().

This method requires SkWriter32 have a contiguous array.
It does, and I plan to keep it that way (last time we checked
it's faster), but this turns that feature back into an 
implementation detail.

This feature is only used by another unused feature, deep copies of
ops arrays in SkPictureData.  Kill that, kill this.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Depends on https://codereview.chromium.org/1936563002/
==========

[mtklein_C, 2016-04-29 18:03:36]

mtklein@chromium.org changed reviewers:
+ brianosman@google.com

[Brian Osman, 2016-04-29 18:13:24]

lgtm

Nice.

[mtklein, 2016-04-29 21:22:06]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 21:22:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1932223003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1932223003/20001

[commit-bot: I haz the power, 2016-04-29 21:38:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 21:38:41]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-04-29 21:39:03]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-04-29 21:39:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1932223003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1932223003/20001

[commit-bot: I haz the power, 2016-04-29 21:40:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 21:40:41]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[mtklein, 2016-04-29 21:44:30]

Description was changed from

==========
Remove SkWriter32::contiguousArray().

This method requires SkWriter32 have a contiguous array.
It does, and I plan to keep it that way (last time we checked
it's faster), but this turns that feature back into an 
implementation detail.

This feature is only used by another unused feature, deep copies of
ops arrays in SkPictureData.  Kill that, kill this.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Depends on https://codereview.chromium.org/1936563002/
==========

to

==========
Remove SkWriter32::contiguousArray().

This method requires SkWriter32 have a contiguous array.
It does, and I plan to keep it that way (last time we checked
it's faster), but this turns that feature back into an 
implementation detail.

This feature is only used by another unused feature, deep copies of
ops arrays in SkPictureData.  Kill that, kill this.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Depends on https://codereview.chromium.org/1936563002/

Only deleting API
TBR=reed@google.com
==========

[mtklein, 2016-04-29 21:44:36]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-04-29 21:44:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1932223003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1932223003/20001

[commit-bot: I haz the power, 2016-04-29 21:45:43]

Description was changed from

==========
Remove SkWriter32::contiguousArray().

This method requires SkWriter32 have a contiguous array.
It does, and I plan to keep it that way (last time we checked
it's faster), but this turns that feature back into an 
implementation detail.

This feature is only used by another unused feature, deep copies of
ops arrays in SkPictureData.  Kill that, kill this.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Depends on https://codereview.chromium.org/1936563002/

Only deleting API
TBR=reed@google.com
==========

to

==========
Remove SkWriter32::contiguousArray().

This method requires SkWriter32 have a contiguous array.
It does, and I plan to keep it that way (last time we checked
it's faster), but this turns that feature back into an 
implementation detail.

This feature is only used by another unused feature, deep copies of
ops arrays in SkPictureData.  Kill that, kill this.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Depends on https://codereview.chromium.org/1936563002/

Only deleting API
TBR=reed@google.com

Committed:
https://skia.googlesource.com/skia/+/4d9ff62fa21326003cf5394cd1d16f4b4633102a
==========

[commit-bot: I haz the power, 2016-04-29 21:45:44]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4d9ff62fa21326003cf5394cd1d16f4b4633102a