Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1932183003: Handle deserialized compilation of closures (Closed)

Created:
4 years, 7 months ago by Johnni Winther
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle deserialized compilation of closures - and fix some errors in serialization and equivalence (test) of ResolvedAst R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/832d87341fb36c5b52cafe039ebc696ebf6a49a0

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -47 lines) Patch
M pkg/compiler/lib/src/closure.dart View 4 chunks +15 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_serialization.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 1 chunk +3 lines, -3 lines 2 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 2 chunks +28 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 3 chunks +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 3 chunks +10 lines, -4 lines 2 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/serialization_compilation_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 7 months ago (2016-04-29 14:03:08 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1932183003/diff/1/pkg/compiler/lib/src/resolution/enum_creator.dart File pkg/compiler/lib/src/resolution/enum_creator.dart (right): https://codereview.chromium.org/1932183003/diff/1/pkg/compiler/lib/src/resolution/enum_creator.dart#newcode257 pkg/compiler/lib/src/resolution/enum_creator.dart:257: new VariableList(valueBuilder.modifiers(isStatic: true, isConst: true)); nit: dartfmt https://codereview.chromium.org/1932183003/diff/1/pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart ...
4 years, 7 months ago (2016-04-30 00:08:11 UTC) #3
Johnni Winther
Committed patchset #1 (id:1) manually as 832d87341fb36c5b52cafe039ebc696ebf6a49a0 (presubmit successful).
4 years, 7 months ago (2016-04-30 09:20:27 UTC) #5
Johnni Winther
4 years, 7 months ago (2016-04-30 09:23:55 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1932183003/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/enum_creator.dart (right):

https://codereview.chromium.org/1932183003/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/enum_creator.dart:257: new
VariableList(valueBuilder.modifiers(isStatic: true, isConst: true));
On 2016/04/30 00:08:11, Siggi Cherem (dart-lang) wrote:
> nit: dartfmt

That's IntelliJ for you! (copied the lines from above)

https://codereview.chromium.org/1932183003/diff/1/pkg/compiler/lib/src/serial...
File pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart (right):

https://codereview.chromium.org/1932183003/diff/1/pkg/compiler/lib/src/serial...
pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart:151: message:
"No index for body of $element: ${resolvedAst.body} ($nodeIndices)."));
On 2016/04/30 00:08:11, Siggi Cherem (dart-lang) wrote:
> nit: 80

Done.

Powered by Google App Engine
This is Rietveld 408576698