Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 1932183002: Add IntDefs to generated Java enums. (Closed)

Created:
4 years, 7 months ago by PEConn
Modified:
4 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add IntDefs to generated Java enums. BUG=607519 TBR=agrieve@chromium.org Committed: https://crrev.com/2e675b536d1e1ed1cf50610fae5ec4960d6cb7a5 Cr-Commit-Position: refs/heads/master@{#408973}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Update deps. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -1 line) Patch
M android_webview/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M base/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M blimp/client/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M build/android/gyp/java_cpp_enum.py View 1 2 chunks +25 lines, -0 lines 0 comments Download
M build/android/gyp/java_cpp_enum_tests.py View 1 1 chunk +10 lines, -0 lines 0 comments Download
M components/bookmarks/common/android/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/cronet/android/BUILD.gn View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M components/sync/android/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M device/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M device/gamepad/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M media/capture/video/android/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/android/BUILD.gn View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ui/accessibility/BUILD.gn View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M ui/android/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 31 (18 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932183002/1
4 years, 7 months ago (2016-04-29 10:18:23 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/175149)
4 years, 7 months ago (2016-04-29 10:25:28 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932183002/20001
4 years, 7 months ago (2016-05-03 10:30:33 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/60473)
4 years, 7 months ago (2016-05-03 10:45:30 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932183002/20001
4 years, 7 months ago (2016-05-20 14:18:45 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/69547)
4 years, 7 months ago (2016-05-20 14:33:55 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932183002/20001
4 years, 6 months ago (2016-06-16 09:36:11 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/21924) ios-device-gn on ...
4 years, 6 months ago (2016-06-16 09:38:40 UTC) #17
PEConn
PTAL!
4 years, 4 months ago (2016-08-01 14:49:40 UTC) #21
Bernhard Bauer
lgtm
4 years, 4 months ago (2016-08-01 14:54:51 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1932183002/60001
4 years, 4 months ago (2016-08-01 15:52:23 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 4 months ago (2016-08-01 15:56:39 UTC) #29
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 15:58:10 UTC) #31
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2e675b536d1e1ed1cf50610fae5ec4960d6cb7a5
Cr-Commit-Position: refs/heads/master@{#408973}

Powered by Google App Engine
This is Rietveld 408576698