RTCCertificate equals method for testing.

content/renderer/media/rtc_certificate.h

Index: content/renderer/media/rtc_certificate.h
diff --git a/content/renderer/media/rtc_certificate.h b/content/renderer/media/rtc_certificate.h
index 60af2492a2eda7e26d98378c3f21d8a57ce3909d..476344dd6b6473406efb93af75f2ac87783220c9 100644
--- a/content/renderer/media/rtc_certificate.h
+++ b/content/renderer/media/rtc_certificate.h
@@ -28,6 +28,7 @@ class RTCCertificate : public blink::WebRTCCertificate {
   std::unique_ptr<blink::WebRTCCertificate> shallowCopy() const override;
   const blink::WebRTCKeyParams& keyParams() const override;
   uint64_t expires() const override;
+  bool equals(const blink::WebRTCCertificate& other) const override;

[tommi (sloooow) - chröme, 2016/04/29 12:50:51]

is this only used for testing?  If so, can it be in test code?

[hbos_chromium, 2016/04/29 13:05:20]

Yes, only test code, but it is part the javascript RTCCertificate and this is
the implementation of the interface providing the RTCCertificate's
functionality. They should be 1:1. Note that the equals function is not visible
in JS unless you enable a RuntimeEnabledFeature for testing.

Moving it elsewhere (say an
RTCCertificateTesting.equals(RTCCertificate,RTCCertificate)) would introduce a
lot of unnecessary complexity (new IDL, .h, .cpp, new blink interface, new
content implementation, new factory). I prefer it to be part of the certificate.

 
   const rtc::scoped_refptr<rtc::RTCCertificate>& rtcCertificate() const;