RTCCertificate equals method for testing.

RTCCertificate equals method for testing.

Adds JavaScript layer RTCCertificate.equals(RTCCertificate) that is only
exposed to tests (behind RuntimeEnabledFeature RTCCertificateTesting).

Blink interface and content implementation updated, the actual
comparison operation is defined in the WebRTC repo between
rtc::RTCCertificate objects.

The test function is not used, but will be used in a follow-up CL that
enables saving and loading RTCCertificate objects in IndexedDB. The
comparison will be used to make sure a clone is equal to the original
certificate.

BUG=chromium:581354
Committed: https://crrev.com/8df58e17b49bc21bc4fe681e0f213f092b6de754
Cr-Commit-Position: refs/heads/master@{#391476}

[hbos_chromium, 2016-04-29 09:22:34]

Patchset #1 (id:1) has been deleted

[hbos_chromium, 2016-04-29 10:34:18]

hbos@chromium.org changed reviewers:
+ jochen@chromium.org, tommi@chromium.org

[hbos_chromium, 2016-04-29 10:34:18]

Please take a look, tommi and jochen

[hbos_chromium, 2016-04-29 10:36:36]

On 2016/04/29 10:34:18, hbos_chromium wrote:
> Please take a look, tommi and jochen

Simple CL (but several layers), just making sure .equals exists which does a ==
b on a lower layer.

[tommi (sloooow) - chröme, 2016-04-29 12:50:51]

https://codereview.chromium.org/1932173002/diff/20001/content/renderer/media/...
File content/renderer/media/rtc_certificate.cc (right):

https://codereview.chromium.org/1932173002/diff/20001/content/renderer/media/...
content/renderer/media/rtc_certificate.cc:36: return *this->certificate_ ==
remove "this->"

https://codereview.chromium.org/1932173002/diff/20001/content/renderer/media/...
File content/renderer/media/rtc_certificate.h (right):

https://codereview.chromium.org/1932173002/diff/20001/content/renderer/media/...
content/renderer/media/rtc_certificate.h:31: bool equals(const
blink::WebRTCCertificate& other) const override;
is this only used for testing?  If so, can it be in test code?

[hbos_chromium, 2016-04-29 13:05:20]

PTAL tommi

https://codereview.chromium.org/1932173002/diff/20001/content/renderer/media/...
File content/renderer/media/rtc_certificate.cc (right):

https://codereview.chromium.org/1932173002/diff/20001/content/renderer/media/...
content/renderer/media/rtc_certificate.cc:36: return *this->certificate_ ==
On 2016/04/29 12:50:51, tommi-chrömium wrote:
> remove "this->"

Done.

https://codereview.chromium.org/1932173002/diff/20001/content/renderer/media/...
File content/renderer/media/rtc_certificate.h (right):

https://codereview.chromium.org/1932173002/diff/20001/content/renderer/media/...
content/renderer/media/rtc_certificate.h:31: bool equals(const
blink::WebRTCCertificate& other) const override;
On 2016/04/29 12:50:51, tommi-chrömium wrote:
> is this only used for testing?  If so, can it be in test code?

Yes, only test code, but it is part the javascript RTCCertificate and this is
the implementation of the interface providing the RTCCertificate's
functionality. They should be 1:1. Note that the equals function is not visible
in JS unless you enable a RuntimeEnabledFeature for testing.

Moving it elsewhere (say an
RTCCertificateTesting.equals(RTCCertificate,RTCCertificate)) would introduce a
lot of unnecessary complexity (new IDL, .h, .cpp, new blink interface, new
content implementation, new factory). I prefer it to be part of the certificate.

[tommi (sloooow) - chröme, 2016-05-01 07:44:35]

lgtm

[hbos_chromium, 2016-05-02 07:55:13]

PTAL jochen :)

[jochen (gone - plz use gerrit), 2016-05-02 16:11:48]

On 2016/05/02 at 07:55:13, hbos wrote:
> PTAL jochen :)

We usually expose such methods on window.internals instead of the actual idl
files. I'd prefer to keep test methods out of idl

[hbos_chromium, 2016-05-03 12:50:25]

PTAL jochen.

Thanks, did not know about internals. I moved RTCCertificate.equals to
window.internals.rtcCertificateEquals. WebRTCCertificate still has the equals
method to go cross blink, content and webrtc layers, but the RTCCertificate.idl
does not have it.

Know how to get access to internals from test code (layout test or browser
test)? Wanting to use this in a follow-up, I always get internals is undefined.

[hbos_chromium, 2016-05-03 12:51:11]

The CQ bit was checked by hbos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 12:52:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1932173002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1932173002/60001

[commit-bot: I haz the power, 2016-05-03 15:36:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 15:36:15]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-05-04 10:44:17]

lgtm

[hbos_chromium, 2016-05-04 10:46:01]

The CQ bit was checked by hbos@chromium.org

[hbos_chromium, 2016-05-04 10:46:01]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/1932173002/#ps60001
(title: "Moved equals test function to internals")

[commit-bot: I haz the power, 2016-05-04 10:46:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1932173002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1932173002/60001

[commit-bot: I haz the power, 2016-05-04 10:49:43]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-05-04 10:50:52]

Description was changed from

==========
RTCCertificate equals method for testing.

Adds JavaScript layer RTCCertificate.equals(RTCCertificate) that is only
exposed to tests (behind RuntimeEnabledFeature RTCCertificateTesting).

Blink interface and content implementation updated, the actual
comparison operation is defined in the WebRTC repo between
rtc::RTCCertificate objects.

The test function is not used, but will be used in a follow-up CL that
enables saving and loading RTCCertificate objects in IndexedDB. The
comparison will be used to make sure a clone is equal to the original
certificate.

BUG=chromium:581354
==========

to

==========
RTCCertificate equals method for testing.

Adds JavaScript layer RTCCertificate.equals(RTCCertificate) that is only
exposed to tests (behind RuntimeEnabledFeature RTCCertificateTesting).

Blink interface and content implementation updated, the actual
comparison operation is defined in the WebRTC repo between
rtc::RTCCertificate objects.

The test function is not used, but will be used in a follow-up CL that
enables saving and loading RTCCertificate objects in IndexedDB. The
comparison will be used to make sure a clone is equal to the original
certificate.

BUG=chromium:581354

Committed: https://crrev.com/8df58e17b49bc21bc4fe681e0f213f092b6de754
Cr-Commit-Position: refs/heads/master@{#391476}
==========

[commit-bot: I haz the power, 2016-05-04 10:50:53]

Patchset 3 (id:??) landed as
https://crrev.com/8df58e17b49bc21bc4fe681e0f213f092b6de754
Cr-Commit-Position: refs/heads/master@{#391476}