Chromium Code Reviews Chromium Code Reviews
Issue 1932143003:
run_isolated: support non-isolated commands (Closed)
Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@run-isolated-download-stats| Index: client/isolateserver.py |
| diff --git a/client/isolateserver.py b/client/isolateserver.py |
| index 33f93ccca56c4b31bd8ae5e0bb40ded404c20049..0b8669df9a4c06ca0addd2bb29156d20036029bd 100755 |
| --- a/client/isolateserver.py |
| +++ b/client/isolateserver.py |
| @@ -2180,13 +2180,17 @@ def add_isolate_server_options(parser): |
| help='The namespace to use on the Isolate Server, default: %default') |
| -def process_isolate_server_options(parser, options, set_exception_handler): |
| - """Processes the --isolate-server option and aborts if not specified. |
| +def process_isolate_server_options( |
| + parser, options, set_exception_handler, required=True): |
|
M-A Ruel
2016/05/02 14:18:14
Can you not make it a default arg and update all c
nodir
2016/05/02 17:43:22
Done in a separate patchset
|
| + """Processes the --isolate-server option. |
| Returns the identity as determined by the server. |
| """ |
| if not options.isolate_server: |
| - parser.error('--isolate-server is required.') |
| + if required: |
| + parser.error('--isolate-server is required.') |
| + return |
| + |
| try: |
| options.isolate_server = net.fix_url(options.isolate_server) |
| except ValueError as e: |
