Only write gyp-win-tool when needed

Only write gyp-win-tool when needed

The gyp-win-tool is written every time .ninja files are regenerated.
This can cause significant overbuild. This change simply avoids writing
it (and touching its time-stamp) if nothing has changed.

A similar fix will be needed for Mac.

BUG=607776
Committed: https://crrev.com/e8cfc6cac3577dc1bd061a59afedb05a5199df3e
Cr-Commit-Position: refs/heads/master@{#390707}

[brucedawson, 2016-04-29 01:55:21]

brucedawson@chromium.org changed reviewers:
+ scottmg@chromium.org

[brucedawson, 2016-04-29 01:55:22]

This explains why my builds rebuild more than I expect. I'll test tomorrow and
see how many targets this actually affects. Any concerns?

[scottmg, 2016-04-29 02:11:40]

gyp has a WriteOnDiff() but it's crazily written, so let's not reuse it. :/

lgtm

https://codereview.chromium.org/1932133002/diff/1/build/toolchain/win/setup_t...
File build/toolchain/win/setup_toolchain.py (right):

https://codereview.chromium.org/1932133002/diff/1/build/toolchain/win/setup_t...
build/toolchain/win/setup_toolchain.py:156: try:
filename = 'gyp-win-tool'

and use in both places.

https://codereview.chromium.org/1932133002/diff/1/build/toolchain/win/setup_t...
build/toolchain/win/setup_toolchain.py:157: with open("gyp-win-tool", 'r') as
tool_file:
Maybe call this read_tool_file and the one below write_tool_file since they're
in the same scope.

https://codereview.chromium.org/1932133002/diff/1/build/toolchain/win/setup_t...
build/toolchain/win/setup_toolchain.py:157: with open("gyp-win-tool", 'r') as
tool_file:
'rb' here, and 'wb' below since we're sort of doing a binary diff.

https://codereview.chromium.org/1932133002/diff/1/build/toolchain/win/setup_t...
build/toolchain/win/setup_toolchain.py:157: with open("gyp-win-tool", 'r') as
tool_file:
" -> ' while you're here (and below).

[brucedawson, 2016-04-29 17:25:28]

Tweaks made.

https://codereview.chromium.org/1932133002/diff/1/build/toolchain/win/setup_t...
File build/toolchain/win/setup_toolchain.py (right):

https://codereview.chromium.org/1932133002/diff/1/build/toolchain/win/setup_t...
build/toolchain/win/setup_toolchain.py:156: try:
On 2016/04/29 02:11:40, scottmg wrote:
> filename = 'gyp-win-tool'
> 
> and use in both places.

Done.

https://codereview.chromium.org/1932133002/diff/1/build/toolchain/win/setup_t...
build/toolchain/win/setup_toolchain.py:157: with open("gyp-win-tool", 'r') as
tool_file:
On 2016/04/29 02:11:40, scottmg wrote:
> " -> ' while you're here (and below).

Yeah, I noticed that and wondered if there was some obscure Python style rule
that had caused double quotes to be used in that one place. Fixed.

https://codereview.chromium.org/1932133002/diff/1/build/toolchain/win/setup_t...
build/toolchain/win/setup_toolchain.py:157: with open("gyp-win-tool", 'r') as
tool_file:
On 2016/04/29 02:11:40, scottmg wrote:
> 'rb' here, and 'wb' below since we're sort of doing a binary diff.

Done.

https://codereview.chromium.org/1932133002/diff/1/build/toolchain/win/setup_t...
build/toolchain/win/setup_toolchain.py:157: with open("gyp-win-tool", 'r') as
tool_file:
On 2016/04/29 02:11:40, scottmg wrote:
> Maybe call this read_tool_file and the one below write_tool_file since they're
> in the same scope.

Done.

[scottmg, 2016-04-29 17:35:04]

lgtm

[brucedawson, 2016-04-29 18:03:46]

On 2016/04/29 17:35:04, scottmg wrote:
> lgtm

I just made a CL to update the mac version which led to me tweaking this one to
keep them more consistent.

[brucedawson, 2016-04-29 18:03:55]

The CQ bit was checked by brucedawson@chromium.org

[brucedawson, 2016-04-29 18:03:55]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1932133002/#ps40001
(title: "Better compatibility with mac version")

[commit-bot: I haz the power, 2016-04-29 18:04:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1932133002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1932133002/40001

[commit-bot: I haz the power, 2016-04-29 18:44:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:27:37]

Patchset 3 (id:??) landed as
https://crrev.com/e8cfc6cac3577dc1bd061a59afedb05a5199df3e
Cr-Commit-Position: refs/heads/master@{#390707}

[commit-bot: I haz the power, 2016-04-30 18:01:36]

Description was changed from

==========
Only write gyp-win-tool when needed

The gyp-win-tool is written every time .ninja files are regenerated.
This can cause significant overbuild. This change simply avoids writing
it (and touching its time-stamp) if nothing has changed.

A similar fix will be needed for Mac.

BUG=607776
==========

to

==========
Only write gyp-win-tool when needed

The gyp-win-tool is written every time .ninja files are regenerated.
This can cause significant overbuild. This change simply avoids writing
it (and touching its time-stamp) if nothing has changed.

A similar fix will be needed for Mac.

BUG=607776

Committed: https://crrev.com/e8cfc6cac3577dc1bd061a59afedb05a5199df3e
Cr-Commit-Position: refs/heads/master@{#390707}
==========