mojo/public/cpp/bindings/tests/validation_unittest.cc - Issue 1932083002: Mojo: Use new message APIs to reduce copying

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/validation_unittest.cc

Issue 1932083002: Mojo: Use new message APIs to reduce copying (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/tests/validation_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/validation_unittest.cc b/mojo/public/cpp/bindings/tests/validation_unittest.cc

index 066d1086bfd0d23dbf213f2a28c8684991c8b807..792af215194536883f6e1489ec47e25b5614c822 100644

--- a/mojo/public/cpp/bindings/tests/validation_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/validation_unittest.cc

@@ -155,7 +155,7 @@ bool ReadTestCase(const std::string& test,

message->Initialize(static_cast<uint32_t>(data.size()),

false /* zero_initialized */);

if (!data.empty())

- memcpy(message->buffer()->Allocate(data.size()), &data[0], data.size());

+ memcpy(message->mutable_data(), &data[0], data.size());

message->mutable_handles()->resize(num_handles);

return true;