Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1932063002: Revert of Add ability to override DEPS file in recursedeps. (Closed)

Created:
4 years, 7 months ago by martiniss
Modified:
4 years, 7 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Add ability to override DEPS file in recursedeps. (patchset #1 id:1 of https://codereview.chromium.org/1919103003/ ) Reason for revert: Looks like this broke some bots; see https://build.chromium.org/p/chromium.infra.cron/builders/recipe-autoroller-public/builds/2960 https://build.chromium.org/p/chromium.infra.cron/builders/gsubtreed-luci-py/builds/52912 Original issue's description: > Add ability to override DEPS file in recursedeps. > > This will allow ANGLE to have a recursible deps-file in their repo instead of > relying on chromium's DEPS file to specify an accurate dependency for itself. > > R=agable@chromium.org, jmadill@chromium.org > BUG= > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300293 TBR=agable@chromium.org,dpranke@chromium.org,jmadill@chromium.org,iannucci@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300304

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -55 lines) Patch
M gclient.py View 4 chunks +6 lines, -19 lines 0 comments Download
M tests/gclient_test.py View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
martiniss
Created Revert of Add ability to override DEPS file in recursedeps.
4 years, 7 months ago (2016-04-28 21:56:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932063002/1
4 years, 7 months ago (2016-04-28 21:56:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300304
4 years, 7 months ago (2016-04-28 21:57:02 UTC) #4
iannucci1
4 years, 7 months ago (2016-04-28 22:23:30 UTC) #5
Message was sent while issue was closed.
On 2016/04/28 21:57:02, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
> http://src.chromium.org/viewvc/chrome?view=rev&revision=300304

I'll have to investigate further. The symptoms on the waterfall is that the
depot_tools deps entry turned into SVN somehow?

Powered by Google App Engine
This is Rietveld 408576698