Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1932033002: Reland of Manual rebaseline for crbug.com/475128 and crbug.com/530044 (Closed)

Created:
4 years, 7 months ago by Xianzhu
Modified:
4 years, 7 months ago
Reviewers:
robertshield
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Manual rebaseline for crbug.com/475128 and crbug.com/530044 (patchset #1 id:1 of https://codereview.chromium.org/1932863002/ ) Reason for revert: The CL is not the cause of the failures. Original issue's description: > Revert of Manual rebaseline for crbug.com/475128 and crbug.com/530044 (patchset #1 id:1 of https://codereview.chromium.org/1925213002/ ) > > Reason for revert: > Reverting as this seems to have broken serveral tests: > > webkit_tests webkit_tests > unexpected_failures: > printing/fixed-positioned-headers-and-footers-inside-transform.html > virtual/threaded/printing/fixed-positioned-headers-and-footers-larger-than-page.html > printing/fixed-positioned-headers-and-footers-larger-than-page.html > virtual/threaded/printing/iframe-print.html > virtual/threaded/printing/subframes-percentage-height.html > virtual/threaded/printing/absolute-position-headers-and-footers.html > printing/absolute-position-headers-and-footers.html > printing/fixed-positioned-but-static-headers-and-footers.html > printing/fixed-positioned-headers-and-footers-clipped.html > virtual/threaded/printing/fixed-positioned-headers-and-footers.html > printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages.html > printing/iframe-print.html > printing/fixed-positioned-headers-and-footers.html > virtual/threaded/printing/fixed-positioned-headers-and-footers-inside-transform.html > virtual/threaded/printing/fixed-positioned-but-static-headers-and-footers.html > virtual/threaded/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages.html > virtual/threaded/printing/fixed-positioned-headers-and-footers-clipped.html > printing/subframes-percentage-height.html > > Link: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/9378 > > Original issue's description: > > Manual rebaseline for crbug.com/475128 and crbug.com/530044 > > > > BUG=475128, 530044 > > TBR=wangxianzhu@chromium.org > > TBR=wangxianzhu@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=475128, 530044 TBR=robertshield@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=475128, 530044 Committed: https://crrev.com/939eccb1e454c6508754f8ce3374252073572840 Cr-Commit-Position: refs/heads/master@{#390466}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -70 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/images/imagemap-focus-ring-in-positioned-container-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/fast/images/imagemap-focus-ring-in-positioned-container-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/images/imagemap-focus-ring-with-paint-root-offset-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/fast/images/imagemap-focus-ring-with-paint-root-offset-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/images/imagemap-focus-ring-with-scale-transform-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/fast/images/imagemap-focus-ring-with-scale-transform-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/android/fast/images/imagemap-focus-ring-with-scale-transform-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/android/transforms/2d/transform-borderbox-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/android/transforms/2d/transform-borderbox-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/android/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-in-positioned-container-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/android/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-with-paint-root-offset-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/android/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-with-scale-transform-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/android/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-with-scale-transform-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux-precise/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-in-positioned-container-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux-precise/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-with-scale-transform-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/images/imagemap-focus-ring-in-positioned-container-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/images/imagemap-focus-ring-in-positioned-container-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/images/imagemap-focus-ring-with-paint-root-offset-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/images/imagemap-focus-ring-with-paint-root-offset-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/images/imagemap-focus-ring-with-scale-transform-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/images/imagemap-focus-ring-with-scale-transform-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/transforms/2d/transform-borderbox-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/transforms/2d/transform-borderbox-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-in-positioned-container-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-in-positioned-container-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-with-paint-root-offset-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-with-paint-root-offset-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-with-scale-transform-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-with-scale-transform-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-zoom-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-in-positioned-container-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-with-scale-transform-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-in-positioned-container-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-with-scale-transform-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-in-positioned-container-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-with-scale-transform-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/fast/images/imagemap-focus-ring-in-positioned-container-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/fast/images/imagemap-focus-ring-in-positioned-container-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/fast/images/imagemap-focus-ring-with-paint-root-offset-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/fast/images/imagemap-focus-ring-with-paint-root-offset-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/fast/images/imagemap-focus-ring-with-scale-transform-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/fast/images/imagemap-focus-ring-with-scale-transform-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/images/imagemap-focus-ring-zoom-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/transforms/2d/transform-borderbox-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/transforms/2d/transform-borderbox-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-in-positioned-container-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-in-positioned-container-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-with-paint-root-offset-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-with-paint-root-offset-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-with-scale-transform-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-with-scale-transform-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-zoom-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/fast/images/imagemap-focus-ring-in-positioned-container-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/fast/images/imagemap-focus-ring-in-positioned-container-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/fast/images/imagemap-focus-ring-with-paint-root-offset-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/fast/images/imagemap-focus-ring-with-paint-root-offset-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/fast/images/imagemap-focus-ring-with-scale-transform-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/fast/images/imagemap-focus-ring-with-scale-transform-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/images/imagemap-focus-ring-zoom-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/transforms/2d/transform-borderbox-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/transforms/2d/transform-borderbox-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-in-positioned-container-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-in-positioned-container-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-with-paint-root-offset-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-with-paint-root-offset-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-with-scale-transform-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-with-scale-transform-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-zoom-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-in-positioned-container-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/fast/images/imagemap-focus-ring-with-scale-transform-expected.png View Binary file 0 comments Download

Messages

Total messages: 5 (1 generated)
Xianzhu
Created Reland of Manual rebaseline for crbug.com/475128 and crbug.com/530044
4 years, 7 months ago (2016-04-28 20:38:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932033002/1
4 years, 7 months ago (2016-04-28 20:38:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 20:40:14 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:20:47 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/939eccb1e454c6508754f8ce3374252073572840
Cr-Commit-Position: refs/heads/master@{#390466}

Powered by Google App Engine
This is Rietveld 408576698