Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1931993002:
Switch ClangToTLinux (dbg) from gyp to gn. (Closed)
DescriptionSwitch ClangToTLinux (dbg) from gyp to gn.
Other ClangToTLinux bots to follow.
BUG=605732
Committed: https://crrev.com/7f0fd54a71eff93fbb3372b0957d373be0860f90
Cr-Commit-Position: refs/heads/master@{#390493}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 15 (6 generated)
thakis@chromium.org changed reviewers: + hans@chromium.org
(Dirk: I wanted to start with the release bot, but I need to figure out the linux_dump_symbols thing first for that.)
(Also, I wanted to ask which BUG= you want me to use for that, but then forgot about that. Sorry about the additional email.)
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
Use bug 605732. linux_dump_symbols hasn't been implemented yet; see bug 605819. Apparently the only people that need it are you and some CrOS bots.
i'm not familiar with how mb works, but seems reasonable to me, so lgtm https://codereview.chromium.org/1931993002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1931993002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:134: 'ClangToTLinux (dbg)': 'swarming_clang_tot_shared_debug', I assume the name on the right just refers to the key further down (line 1600), not some actual buildbot config or something?
On 2016/04/28 20:30:42, hans wrote: > i'm not familiar with how mb works, but seems reasonable to me, so lgtm > > https://codereview.chromium.org/1931993002/diff/1/tools/mb/mb_config.pyl > File tools/mb/mb_config.pyl (right): > > https://codereview.chromium.org/1931993002/diff/1/tools/mb/mb_config.pyl#newc... > tools/mb/mb_config.pyl:134: 'ClangToTLinux (dbg)': > 'swarming_clang_tot_shared_debug', > I assume the name on the right just refers to the key further down (line 1600), > not some actual buildbot config or something? Correct.
Description was changed from ========== Switch ClangToTLinux (dbg) from gyp to gn. Other ClangToTLinux bots to follow. BUG=XXX ========== to ========== Switch ClangToTLinux (dbg) from gyp to gn. Other ClangToTLinux bots to follow. BUG=605732 ==========
On 2016/04/28 20:26:05, Dirk Pranke wrote: > Use bug 605732. > > linux_dump_symbols hasn't been implemented yet; see bug 605819. Apparently the > only people that need it are you and some CrOS bots. All we need is a way to force -g on (to test optimized debug info) -- that's all linux_dump_symbols means nowadays. Shouldn't be super hard to do, I just need to do it.
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931993002/1
Message was sent while issue was closed.
Description was changed from ========== Switch ClangToTLinux (dbg) from gyp to gn. Other ClangToTLinux bots to follow. BUG=605732 ========== to ========== Switch ClangToTLinux (dbg) from gyp to gn. Other ClangToTLinux bots to follow. BUG=605732 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7f0fd54a71eff93fbb3372b0957d373be0860f90 Cr-Commit-Position: refs/heads/master@{#390493}
Message was sent while issue was closed.
Description was changed from ========== Switch ClangToTLinux (dbg) from gyp to gn. Other ClangToTLinux bots to follow. BUG=605732 ========== to ========== Switch ClangToTLinux (dbg) from gyp to gn. Other ClangToTLinux bots to follow. BUG=605732 Committed: https://crrev.com/7f0fd54a71eff93fbb3372b0957d373be0860f90 Cr-Commit-Position: refs/heads/master@{#390493} ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
