Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 1931973002: Unship try-catch and try-finally optimizations in Turbofan. (Closed)

Created:
4 years, 7 months ago by Jarin
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Michael Starzinger, Michael Hablich, mvstanton
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Unship try-catch and try-finally optimizations in Turbofan. Try catch interacts badly with OSR and for-in. BUG=chromium:607493 LOG=n Committed: https://crrev.com/a5c6676b136457266e8e10bf3f7df30a5184aa3b Cr-Commit-Position: refs/heads/master@{#35877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/ast/ast-numbering.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please?
4 years, 7 months ago (2016-04-28 18:31:34 UTC) #2
Benedikt Meurer
LGTM
4 years, 7 months ago (2016-04-28 18:36:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931973002/1
4 years, 7 months ago (2016-04-28 18:36:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 18:59:02 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:02:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5c6676b136457266e8e10bf3f7df30a5184aa3b
Cr-Commit-Position: refs/heads/master@{#35877}

Powered by Google App Engine
This is Rietveld 408576698